Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Issue 1235433005: Add pcap support to bwe tools. Allow filtering on SSRCs. (Closed)

Created:
5 years, 5 months ago by stefan-webrtc
Modified:
5 years, 5 months ago
Reviewers:
pbos-webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, stefan-webrtc, mflodman
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Add pcap support to bwe tools. Allow filtering on SSRCs. Also switches the command line interface to gflags. Committed: https://crrev.com/b947f287a6c9e209256d279345f334752a5aaf1b Cr-Commit-Position: refs/heads/master@{#9599}

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : . #

Total comments: 1

Patch Set 4 : Simplify parsing of ssrcs. #

Patch Set 5 : Simplify filename parsing. #

Patch Set 6 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+129 lines, -60 lines) Patch
M webrtc/modules/remote_bitrate_estimator/remote_bitrate_estimator.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/modules/remote_bitrate_estimator/tools/bwe_rtp.cc View 1 2 3 4 3 chunks +73 lines, -9 lines 0 comments Download
M webrtc/modules/remote_bitrate_estimator/tools/bwe_rtp_play.cc View 2 chunks +17 lines, -24 lines 0 comments Download
M webrtc/modules/remote_bitrate_estimator/tools/rtp_to_text.cc View 1 chunk +0 lines, -11 lines 0 comments Download
M webrtc/test/rtp_file_reader.h View 2 chunks +4 lines, -0 lines 0 comments Download
M webrtc/test/rtp_file_reader.cc View 1 2 3 4 5 10 chunks +34 lines, -16 lines 0 comments Download

Messages

Total messages: 21 (8 generated)
stefan-webrtc
5 years, 5 months ago (2015-07-15 14:13:22 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1235433005/40001
5 years, 5 months ago (2015-07-15 14:13:39 UTC) #4
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. Only full committers are accepted. Even if an ...
5 years, 5 months ago (2015-07-15 14:13:41 UTC) #6
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1235433005/40001
5 years, 5 months ago (2015-07-15 14:34:27 UTC) #8
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: win_x64_rel on tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/win_x64_rel/builds/8395)
5 years, 5 months ago (2015-07-15 14:38:05 UTC) #10
pbos-webrtc
https://codereview.webrtc.org/1235433005/diff/40001/webrtc/modules/remote_bitrate_estimator/tools/bwe_rtp.cc File webrtc/modules/remote_bitrate_estimator/tools/bwe_rtp.cc (right): https://codereview.webrtc.org/1235433005/diff/40001/webrtc/modules/remote_bitrate_estimator/tools/bwe_rtp.cc#newcode91 webrtc/modules/remote_bitrate_estimator/tools/bwe_rtp.cc:91: if (filename.substr(filename.find_last_of(".") + 1).substr(0, 4) == "pcap") { filename.substr(filename.find_last_offind_last_of(".") ...
5 years, 5 months ago (2015-07-15 14:50:26 UTC) #11
stefan-webrtc
Comments addressed
5 years, 5 months ago (2015-07-15 14:51:42 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1235433005/100001
5 years, 5 months ago (2015-07-15 14:56:53 UTC) #14
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. Only full committers are accepted. Even if an ...
5 years, 5 months ago (2015-07-15 14:56:55 UTC) #16
pbos-webrtc
lgtm
5 years, 5 months ago (2015-07-15 14:56:57 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1235433005/100001
5 years, 5 months ago (2015-07-17 11:12:08 UTC) #19
commit-bot: I haz the power
Committed patchset #6 (id:100001)
5 years, 5 months ago (2015-07-17 12:27:25 UTC) #20
commit-bot: I haz the power
5 years, 5 months ago (2015-07-17 12:27:38 UTC) #21
Message was sent while issue was closed.
Patchset 6 (id:??) landed as
https://crrev.com/b947f287a6c9e209256d279345f334752a5aaf1b
Cr-Commit-Position: refs/heads/master@{#9599}

Powered by Google App Engine
This is Rietveld 408576698