Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(153)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1235263003: Add thread checker to StatsCollection. (Closed)

Created:
5 years, 5 months ago by joachim
Modified:
5 years, 4 months ago
Reviewers:
tommi
CC:
webrtc-reviews_webrtc.org, interface-changes_webrtc.org, rwolff_gocast.it, yujie_mao (webrtc), Andrew MacDonald, tterriberry_mozilla.com, qiang.lu, niklas.enbom
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Add thread checker to StatsCollection. This CL makes sure the methods are always called on the correct thread. Committed: https://crrev.com/25c96d02cdd2460b378ab89e4b90b17a81bf0d4a Cr-Commit-Position: refs/heads/master@{#9688}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Fixed #include #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -1 line) Patch
M talk/app/webrtc/statstypes.h View 1 3 chunks +2 lines, -1 line 0 comments Download
M talk/app/webrtc/statstypes.cc View 3 chunks +8 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (5 generated)
joachim
Ptal, this implements one of your todos ;-)
5 years, 5 months ago (2015-07-15 23:52:45 UTC) #2
joachim
Ping?
5 years, 4 months ago (2015-08-07 13:00:58 UTC) #3
tommi
lgtm W00t! :D Thanks for taking care of this. Just got back from vacation hence ...
5 years, 4 months ago (2015-08-07 13:05:04 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1235263003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1235263003/1
5 years, 4 months ago (2015-08-07 13:05:12 UTC) #6
tommi
https://codereview.webrtc.org/1235263003/diff/1/talk/app/webrtc/statstypes.h File talk/app/webrtc/statstypes.h (right): https://codereview.webrtc.org/1235263003/diff/1/talk/app/webrtc/statstypes.h#newcode46 talk/app/webrtc/statstypes.h:46: #include <webrtc/base/thread_checker.h> oh, missed this... should be "
5 years, 4 months ago (2015-08-07 13:06:07 UTC) #8
joachim
https://codereview.webrtc.org/1235263003/diff/1/talk/app/webrtc/statstypes.h File talk/app/webrtc/statstypes.h (right): https://codereview.webrtc.org/1235263003/diff/1/talk/app/webrtc/statstypes.h#newcode46 talk/app/webrtc/statstypes.h:46: #include <webrtc/base/thread_checker.h> On 2015/08/07 13:06:07, tommi (webrtc) wrote: > ...
5 years, 4 months ago (2015-08-07 13:08:51 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1235263003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1235263003/20001
5 years, 4 months ago (2015-08-07 16:01:13 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 4 months ago (2015-08-07 16:48:23 UTC) #13
commit-bot: I haz the power
5 years, 4 months ago (2015-08-07 16:48:27 UTC) #14
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/25c96d02cdd2460b378ab89e4b90b17a81bf0d4a
Cr-Commit-Position: refs/heads/master@{#9688}

Powered by Google App Engine
This is Rietveld 408576698