Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(493)

Unified Diff: webrtc/modules/remote_bitrate_estimator/test/estimators/nada.h

Issue 1235143002: Fix simulator issue where chokes didn't apply to non-congested packets. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Comments addressed. Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/modules/remote_bitrate_estimator/test/estimators/nada.h
diff --git a/webrtc/modules/remote_bitrate_estimator/test/estimators/nada.h b/webrtc/modules/remote_bitrate_estimator/test/estimators/nada.h
index 6fea6240355da1cb1fb3a09cda75895a5029d8a7..75dc94d0a9efbe2145ceb4dc7e41a82dec723813 100644
--- a/webrtc/modules/remote_bitrate_estimator/test/estimators/nada.h
+++ b/webrtc/modules/remote_bitrate_estimator/test/estimators/nada.h
@@ -46,7 +46,7 @@ class NadaBweReceiver : public BweReceiver {
int64_t last_smoothed_value,
float alpha);
- static const int64_t kReceivingRateTimeWindowMs = 500;
+ static const int64_t kReceivingRateTimeWindowMs;
private:
SimulatedClock clock_;
@@ -58,9 +58,7 @@ class NadaBweReceiver : public BweReceiver {
int last_delays_index_;
int64_t exp_smoothed_delay_ms_; // Referred as d_hat_n.
int64_t est_queuing_delay_signal_ms_; // Referred as d_tilde_n.
-
- static const int kMedian = 5; // Used for k-points Median Filter.
- int64_t last_delays_ms_[kMedian]; // Used for Median Filter.
+ int64_t last_delays_ms_[5]; // Used for Median Filter.
};
class NadaBweSender : public BweSender {
@@ -89,8 +87,8 @@ class NadaBweSender : public BweSender {
}
int64_t NowMs() const { return clock_->TimeInMilliseconds(); }
- static const int kMinRefRateKbps = 150; // Referred as R_min.
- static const int kMaxRefRateKbps = 1500; // Referred as R_max.
+ static const int kMinRefRateKbps; // Referred as R_min.
+ static const int kMaxRefRateKbps; // Referred as R_max.
private:
Clock* const clock_;

Powered by Google App Engine
This is Rietveld 408576698