Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(57)

Issue 1233853002: Fix simulator issue where chokes didn't apply to non-congested packets. (Closed)

Created:
5 years, 5 months ago by stefan-webrtc
Modified:
5 years, 5 months ago
Reviewers:
magalhaesc1, magalhaesc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, mflodman
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Fix simulator issue where chokes didn't apply to non-congested packets. R=magalhaesc@google.com Committed: https://chromium.googlesource.com/external/webrtc/+/662ae00efaa71fbb964eba44b60de4567fc36a73

Patch Set 1 #

Total comments: 1

Patch Set 2 : Added and fixed existing unittests. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -10 lines) Patch
M webrtc/modules/modules.gyp View 1 1 chunk +2 lines, -0 lines 0 comments Download
M webrtc/modules/remote_bitrate_estimator/remote_bitrate_estimator.gypi View 1 2 chunks +0 lines, -2 lines 0 comments Download
M webrtc/modules/remote_bitrate_estimator/test/bwe_test_framework.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M webrtc/modules/remote_bitrate_estimator/test/bwe_test_framework_unittest.cc View 1 3 chunks +31 lines, -5 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
stefan-webrtc
5 years, 5 months ago (2015-07-13 12:57:11 UTC) #2
magalhaesc
lgtm https://codereview.webrtc.org/1233853002/diff/1/webrtc/modules/remote_bitrate_estimator/test/bwe_test_framework.cc File webrtc/modules/remote_bitrate_estimator/test/bwe_test_framework.cc (right): https://codereview.webrtc.org/1233853002/diff/1/webrtc/modules/remote_bitrate_estimator/test/bwe_test_framework.cc#newcode433 webrtc/modules/remote_bitrate_estimator/test/bwe_test_framework.cc:433: int64_t earliest_send_time_us = LGTM
5 years, 5 months ago (2015-07-13 13:07:59 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1233853002/20001
5 years, 5 months ago (2015-07-13 15:29:54 UTC) #7
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. Only full committers are accepted. Even if an ...
5 years, 5 months ago (2015-07-13 15:29:57 UTC) #9
stefan-webrtc
Committed patchset #2 (id:20001) manually as 662ae00efaa71fbb964eba44b60de4567fc36a73 (presubmit successful).
5 years, 5 months ago (2015-07-13 15:32:41 UTC) #10
stefan-webrtc
5 years, 5 months ago (2015-07-13 15:37:26 UTC) #11
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.webrtc.org/1230383003/ by stefan@webrtc.org.

The reason for reverting is: Breaks bots..

Powered by Google App Engine
This is Rietveld 408576698