Add methods to set the ICE connection receiving_timeout values.

Add methods to set the ICE connection receiving_timeout values.

BUG=

Committed: https://crrev.com/900996290c996193ac3e418f315354fd2bd0ea8a
Cr-Commit-Position: refs/heads/master@{#9572}

[honghaiz3, 2015-07-09 21:32:34]

Patchset #1 (id:1) has been deleted

[honghaiz3, 2015-07-09 21:32:42]

Patchset #1 (id:20001) has been deleted

[honghaiz3, 2015-07-09 21:32:52]

Patchset #1 (id:40001) has been deleted

[honghaiz3, 2015-07-09 21:34:38]

honghaiz@webrtc.org changed reviewers:
+ pthatcher@webrtc.org

[honghaiz3, 2015-07-09 22:00:44]

Patchset #2 (id:60001) has been deleted

[pthatcher1, 2015-07-09 22:21:41]

We might want some unit tests for the scenario of:

1.  Set the value.
2.  Create some new transports/channels.  
3.  Make sure the new ones have the value.

This is most relevant for the situation where we start a call with audio and
then add video later.

https://codereview.webrtc.org/1231913003/diff/50001/talk/app/webrtc/webrtcses...
File talk/app/webrtc/webrtcsession.cc (right):

https://codereview.webrtc.org/1231913003/diff/50001/talk/app/webrtc/webrtcses...
talk/app/webrtc/webrtcsession.cc:1439:
transport->SetChannelReceivingTimeout(timeout_ms);
We should pass down the value to each Transport even if it doesn't have
Channels, and then each Transport needs to remember it and apply it to each new
TransportChannel that it creates.

https://codereview.webrtc.org/1231913003/diff/50001/talk/app/webrtc/webrtcses...
talk/app/webrtc/webrtcsession.cc:1441: }
I think we need to store the value and then apply it to each Transport that we
create when we create them.  Such logic probably belongs in BaseSession, not
WebRtcSession.  It would be better if we already had the TransportController
class instead of BaseSession, but BaseSession should work for now.

https://codereview.webrtc.org/1231913003/diff/50001/webrtc/p2p/base/transport.cc
File webrtc/p2p/base/transport.cc (right):

https://codereview.webrtc.org/1231913003/diff/50001/webrtc/p2p/base/transport...
webrtc/p2p/base/transport.cc:186: }
The Transport needs to remember the value and apply it to each Channel that is
created after the value is set.

[honghaiz3, 2015-07-10 20:11:21]

Patchset #2 (id:80001) has been deleted

[honghaiz3, 2015-07-10 20:21:20]

Patchset #2 (id:100001) has been deleted

[honghaiz3, 2015-07-10 20:22:25]

Thanks! PTAL.

[pthatcher1, 2015-07-11 00:24:54]

lgtm, if you address the three remaining things

https://codereview.webrtc.org/1231913003/diff/100002/webrtc/p2p/base/p2ptrans...
File webrtc/p2p/base/p2ptransportchannel.cc (right):

https://codereview.webrtc.org/1231913003/diff/100002/webrtc/p2p/base/p2ptrans...
webrtc/p2p/base/p2ptransportchannel.cc:364: return;
At least log a warning.

https://codereview.webrtc.org/1231913003/diff/100002/webrtc/p2p/base/session_...
File webrtc/p2p/base/session_unittest.cc (right):

https://codereview.webrtc.org/1231913003/diff/100002/webrtc/p2p/base/session_...
webrtc/p2p/base/session_unittest.cc:58: false)) {}
Can you run "git cl format"?  This format looks kind of weird to me.

https://codereview.webrtc.org/1231913003/diff/100002/webrtc/p2p/p2p_tests.gypi
File webrtc/p2p/p2p_tests.gypi (right):

https://codereview.webrtc.org/1231913003/diff/100002/webrtc/p2p/p2p_tests.gyp...
webrtc/p2p/p2p_tests.gypi:24: 'base/session_unittest.cc',
You may need to add to the BUILD.gn file as well to not break the GN build bots.

[honghaiz3, 2015-07-11 02:59:17]

On 2015/07/11 00:24:54, pthatcher1 wrote:
> lgtm, if you address the three remaining things
> 
>
https://codereview.webrtc.org/1231913003/diff/100002/webrtc/p2p/base/p2ptrans...
> File webrtc/p2p/base/p2ptransportchannel.cc (right):
> 
>
https://codereview.webrtc.org/1231913003/diff/100002/webrtc/p2p/base/p2ptrans...
> webrtc/p2p/base/p2ptransportchannel.cc:364: return;
> At least log a warning.
> 
>
https://codereview.webrtc.org/1231913003/diff/100002/webrtc/p2p/base/session_...
> File webrtc/p2p/base/session_unittest.cc (right):
> 
>
https://codereview.webrtc.org/1231913003/diff/100002/webrtc/p2p/base/session_...
> webrtc/p2p/base/session_unittest.cc:58: false)) {}
> Can you run "git cl format"?  This format looks kind of weird to me.
> 
> https://codereview.webrtc.org/1231913003/diff/100002/webrtc/p2p/p2p_tests.gypi
> File webrtc/p2p/p2p_tests.gypi (right):
> 
>
https://codereview.webrtc.org/1231913003/diff/100002/webrtc/p2p/p2p_tests.gyp...
> webrtc/p2p/p2p_tests.gypi:24: 'base/session_unittest.cc',
> You may need to add to the BUILD.gn file as well to not break the GN build
bots.
Addressed comments.

[honghaiz3, 2015-07-11 03:00:06]

The CQ bit was checked by honghaiz@webrtc.org to run a CQ dry run

[honghaiz3, 2015-07-11 03:00:06]

The patchset sent to the CQ was uploaded after l-g-t-m from pthatcher@webrtc.org
Link to the patchset: https://codereview.webrtc.org/1231913003/#ps130001 (title:
"Address comments")

[commit-bot: I haz the power, 2015-07-11 03:00:19]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1231913003/130001

[commit-bot: I haz the power, 2015-07-11 05:15:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-07-11 05:15:43]

Dry run: This issue passed the CQ dry run.

[honghaiz3, 2015-07-13 18:34:43]

The CQ bit was checked by honghaiz@webrtc.org

[commit-bot: I haz the power, 2015-07-13 18:35:05]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1231913003/130001

[commit-bot: I haz the power, 2015-07-13 19:19:40]

Committed patchset #3 (id:130001)

[commit-bot: I haz the power, 2015-07-13 19:19:52]

Patchset 3 (id:??) landed as
https://crrev.com/900996290c996193ac3e418f315354fd2bd0ea8a
Cr-Commit-Position: refs/heads/master@{#9572}

[honghaiz3, 2015-08-05 23:57:39]

Publishing some draft responses that should have been sent earlier.

https://codereview.webrtc.org/1231913003/diff/50001/talk/app/webrtc/webrtcses...
File talk/app/webrtc/webrtcsession.cc (right):

https://codereview.webrtc.org/1231913003/diff/50001/talk/app/webrtc/webrtcses...
talk/app/webrtc/webrtcsession.cc:1439:
transport->SetChannelReceivingTimeout(timeout_ms);
On 2015/07/09 22:21:41, pthatcher1 wrote:
> We should pass down the value to each Transport even if it doesn't have
> Channels, and then each Transport needs to remember it and apply it to each
new
> TransportChannel that it creates.

Done.

https://codereview.webrtc.org/1231913003/diff/50001/talk/app/webrtc/webrtcses...
talk/app/webrtc/webrtcsession.cc:1441: }
On 2015/07/09 22:21:41, pthatcher1 wrote:
> I think we need to store the value and then apply it to each Transport that we
> create when we create them.  Such logic probably belongs in BaseSession, not
> WebRtcSession.  It would be better if we already had the TransportController
> class instead of BaseSession, but BaseSession should work for now.

Done.

https://codereview.webrtc.org/1231913003/diff/50001/webrtc/p2p/base/transport.cc
File webrtc/p2p/base/transport.cc (right):

https://codereview.webrtc.org/1231913003/diff/50001/webrtc/p2p/base/transport...
webrtc/p2p/base/transport.cc:186: }
On 2015/07/09 22:21:41, pthatcher1 wrote:
> The Transport needs to remember the value and apply it to each Channel that is
> created after the value is set.

Done.

https://codereview.webrtc.org/1231913003/diff/100002/webrtc/p2p/base/p2ptrans...
File webrtc/p2p/base/p2ptransportchannel.cc (right):

https://codereview.webrtc.org/1231913003/diff/100002/webrtc/p2p/base/p2ptrans...
webrtc/p2p/base/p2ptransportchannel.cc:364: return;
On 2015/07/11 00:24:53, pthatcher1 wrote:
> At least log a warning.
This also happens in the default case where users have not set the receiving
timeout. 
So better not log anything.

https://codereview.webrtc.org/1231913003/diff/100002/webrtc/p2p/base/session_...
File webrtc/p2p/base/session_unittest.cc (right):

https://codereview.webrtc.org/1231913003/diff/100002/webrtc/p2p/base/session_...
webrtc/p2p/base/session_unittest.cc:58: false)) {}
On 2015/07/11 00:24:54, pthatcher1 wrote:
> Can you run "git cl format"?  This format looks kind of weird to me.

Done. This also fixed the formatting of a few other files in this CL.

https://codereview.webrtc.org/1231913003/diff/100002/webrtc/p2p/p2p_tests.gypi
File webrtc/p2p/p2p_tests.gypi (right):

https://codereview.webrtc.org/1231913003/diff/100002/webrtc/p2p/p2p_tests.gyp...
webrtc/p2p/p2p_tests.gypi:24: 'base/session_unittest.cc',
On 2015/07/11 00:24:54, pthatcher1 wrote:
> You may need to add to the BUILD.gn file as well to not break the GN build
bots.

I looked other files. It seems that BUILD.gn does not contains unittest files.
For example, I do not see relayserver_unittest showed anywhere else.