Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1231663002:
Make .gni less sensitive to type of arm_use_neon flags (Closed)
|
Created:
5 years, 5 months ago by Peter Mayo Modified:
5 years, 5 months ago CC:
webrtc-reviews_webrtc.org, kjellander_webrtc, Dirk Pranke Base URL:
https://chromium.googlesource.com/external/webrtc/trunk/webrtc.git@master Target Ref:
refs/pending/heads/master Project:
webrtc Visibility:
Public. |
DescriptionMake .gni less sensitive to type of arm_use_neon flags
Comparing with 1 is less clear than using the input flags as
booleans.
BUG=5008276
Committed: https://crrev.com/50cf10d82a5f04cfe15867a822d4a7a7d579aa02
Cr-Commit-Position: refs/heads/master@{#9561}
Patch Set 1 #Patch Set 2 : Rebase to master #Patch Set 3 : Move base to webrtc project #Patch Set 4 : Ran gn format as presubmit requested #Messages
Total messages: 23 (8 generated)
petermayo@chromium.org changed reviewers: + kjellander@webrtc.org
petermayo@chromium.org changed reviewers: + phoglund@webrtc.org - kjellander@webrtc.org
Any chance phoglund@ knows about this before kjellander@ gets back?
Sure! lgtm
On 2015/07/09 07:52:04, phoglund wrote: > Sure! lgtm Although note, I'm going on vacation after tomorrow.
The CQ bit was checked by petermayo@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1231663002/1
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: android_clang on tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/android_clang/builds/6491) ios_arm64 on tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/ios_arm64/builds/3305) ios_rel on tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/ios_rel/builds/7048) linux on tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/linux/builds/8458) linux_asan on tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/linux_asan/builds/8245) linux_gn on tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/linux_gn/builds/4498) linux_gn_rel on tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/linux_gn_rel/builds/4445) linux_tsan2 on tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/linux_tsan2/builds/5656) mac_x64_gn on tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/mac_x64_gn/builds/2952) win_rel on tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/win_rel/builds/8465) win_x64_rel on tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/win_x64_rel/builds/8265) (exceeded global retry quota)
Rebase to master
Move base to webrtc project
Ran gn format as presubmit requested
The CQ bit was checked by petermayo@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from phoglund@webrtc.org Link to the patchset: https://codereview.webrtc.org/1231663002/#ps60001 (title: "Ran gn format as presubmit requested")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1231663002/60001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: presubmit on tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/presubmit/builds/131)
LGTM % (the fact that I don't know the details)
The CQ bit was checked by petermayo@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1231663002/60001
Message was sent while issue was closed.
Committed patchset #4 (id:60001)
Message was sent while issue was closed.
Patchset 4 (id:??) landed as https://crrev.com/50cf10d82a5f04cfe15867a822d4a7a7d579aa02 Cr-Commit-Position: refs/heads/master@{#9561} |
