Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(864)

Issue 1231653003: Removed some unused variables in Windows code. (Closed)

Created:
5 years, 5 months ago by Matt Giuca
Modified:
5 years, 5 months ago
Reviewers:
Sergey Ulanov
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, chrome-apps-syd-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Removed some unused variables in Windows code. Note: Regarding the ICMP6_CLOSE_FUNC variable in winping.cc, Icmp6CloseHandle does not exist, and IcmpCloseHandle is the correct way to close an IPv6 handle. Therefore the existing code is correct to use close_ on both types of connections and this variable is unnecessary. BUG=505319 Committed: https://crrev.com/e987a47f95abc4fe9ea649cf9e70eaf30175f813 Cr-Commit-Position: refs/heads/master@{#9555}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -2 lines) Patch
M webrtc/base/winping.cc View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/modules/desktop_capture/win/cursor.cc View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 14 (4 generated)
Matt Giuca
Copy of https://codereview.webrtc.org/1214713005/ but landing on the right base URL this time.
5 years, 5 months ago (2015-07-09 00:40:49 UTC) #2
Matt Giuca
Copy of https://codereview.webrtc.org/1214713005/ but landing on the right base URL this time.
5 years, 5 months ago (2015-07-09 00:40:50 UTC) #3
Sergey Ulanov
lgtm
5 years, 5 months ago (2015-07-09 00:44:45 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1231653003/1
5 years, 5 months ago (2015-07-09 00:59:30 UTC) #6
Matt Giuca
Thanks! (Now we'll see if the CQ works here, otherwise I'll git cl land.)
5 years, 5 months ago (2015-07-09 00:59:35 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: linux_msan on tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/linux_msan/builds/3587)
5 years, 5 months ago (2015-07-09 01:44:33 UTC) #9
Matt Giuca
Looks like this test was designed to be flaky...
5 years, 5 months ago (2015-07-09 07:25:34 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1231653003/1
5 years, 5 months ago (2015-07-09 07:25:48 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 5 months ago (2015-07-09 07:53:59 UTC) #13
commit-bot: I haz the power
5 years, 5 months ago (2015-07-09 07:54:11 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e987a47f95abc4fe9ea649cf9e70eaf30175f813
Cr-Commit-Position: refs/heads/master@{#9555}

Powered by Google App Engine
This is Rietveld 408576698