Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(131)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1231033002: Revert the process noise co-variance of the bitrate over-use estimator to its value prior to r9545. (Closed)

Created:
5 years, 5 months ago by stefan-webrtc
Modified:
5 years, 5 months ago
Reviewers:
tommi, pbos-webrtc
CC:
webrtc-reviews_webrtc.org, interface-changes_webrtc.org, rwolff_gocast.it, yujie_mao (webrtc), Andrew MacDonald, tterriberry_mozilla.com, qiang.lu, niklas.enbom
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Revert the process noise co-variance of the bitrate over-use estimator to its value prior to r9545. R=pbos@webrtc.org TBR=tommi@webrtc.org BUG=crbug:508678 Committed: https://chromium.googlesource.com/external/webrtc/+/8647922ea7ce7d534d7060801afc918d2d3a7fe0

Patch Set 1 #

Patch Set 2 : Tests fixed. #

Total comments: 1

Patch Set 3 : Comment addressed. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -35 lines) Patch
M webrtc/common_types.h View 1 2 2 chunks +2 lines, -4 lines 0 comments Download
M webrtc/modules/remote_bitrate_estimator/overuse_detector_unittest.cc View 1 23 chunks +30 lines, -30 lines 0 comments Download
M webrtc/modules/remote_bitrate_estimator/remote_bitrate_estimator_unittest_helper.cc View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
stefan-webrtc
5 years, 5 months ago (2015-07-10 09:17:20 UTC) #2
pbos-webrtc
lgtm, but please say "bitrate-overuse process noise" or something that's more specific than "the process ...
5 years, 5 months ago (2015-07-10 09:20:23 UTC) #3
pbos-webrtc
lgtm, but please say "bitrate-overuse process noise" or something that's more specific than "the process ...
5 years, 5 months ago (2015-07-10 09:20:25 UTC) #4
stefan-webrtc
TBR tommi for common_types.h
5 years, 5 months ago (2015-07-10 09:28:32 UTC) #6
stefan-webrtc
5 years, 5 months ago (2015-07-10 09:28:53 UTC) #7
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) manually as
8647922ea7ce7d534d7060801afc918d2d3a7fe0 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698