Adds logging of configuration information for VideoReceiveStream

webrtc/video/rtc_event_log.h

+/*
+ *  Copyright (c) 2015 The WebRTC project authors. All Rights Reserved.
+ *
+ *  Use of this source code is governed by a BSD-style license
+ *  that can be found in the LICENSE file in the root of the source
+ *  tree. An additional intellectual property rights grant can be found
+ *  in the file PATENTS.  All contributing project authors may
+ *  be found in the AUTHORS file in the root of the source tree.
+ */
+
+#ifndef WEBRTC_VIDEO_RTC_EVENT_LOG_H_
+#define WEBRTC_VIDEO_RTC_EVENT_LOG_H_
+
+#include <string>
+
+#include "webrtc/base/scoped_ptr.h"
+#include "webrtc/video_receive_stream.h"
+#include "webrtc/video_send_stream.h"
+
+
+namespace webrtc {
+
+// Forward declaration of storage class that is automatically generated from
+// the protobuf file.
+class RelEventStream;
+
+class RtcEventLogImpl;
+
+enum class MediaType;
+
+class RtcEventLog {
+ public:
+  // The types of debug events that are currently supported for logging.
+  enum class DebugEvent { kLogStart, kLogEnd, kAudioPlayout };
+
+  virtual ~RtcEventLog() {}
+
+  static rtc::scoped_ptr<RtcEventLog> Create();
+
+  // Starts logging for the specified duration to the specified file.
+  // The logging will stop automatically after the specified duration.
+  // If the file already exists it will be overwritten.
+  // If the file cannot be opened, the RtcEventLog will not start logging.
+  virtual void StartLogging(const std::string& file_name, int duration_ms) = 0;
+
+  // Logs configuration information for webrtc::VideoReceiveStream
+  virtual void LogVideoReceiveStreamConfig(
+      const webrtc::VideoReceiveStream::Config& config) = 0;
+
+  // Logs configuration information for webrtc::VideoSendStream
+  virtual void LogVideoSendStreamConfig(
+      const webrtc::VideoSendStream::Config& config) = 0;
+
+  // Logs the header of an incoming or outgoing RTP packet.
+  virtual void LogRtpHeader(bool incoming,
+                            MediaType media_type,
+                            const uint8_t* header,
+                            size_t header_length,
+                            size_t total_length) = 0;
+
+  // Logs an incoming or outgoing RTCP packet.
+  virtual void LogRtcpPacket(bool incoming,
+                             MediaType media_type,
+                             const uint8_t* packet,
+                             size_t length) = 0;
+
+  // Logs a debug event, with optional message.
+  virtual void LogDebugEvent(DebugEvent event_type,
+                             const std::string& event_message) = 0;

[pbos-webrtc, 2015/07/22 11:05:27]

If these are always used as constants, can you make this one a const char*
event_message so we don't have to do string construction?

[terelius, 2015/07/23 15:54:01]

Removed message field from protobuf because the message was always an empty
string.

+  virtual void LogDebugEvent(DebugEvent event_type) = 0;

[pbos-webrtc, 2015/07/22 11:05:27]

Do you need this one?

[terelius, 2015/07/23 15:54:01]

This is now the only function to log debug events.

+
+  // Reads an RtcEventLog file and returns true when reading was successful.
+  // The result is stored in the given RelEventStream object.
+  static bool ParseRtcEventLog(const std::string& file_name,

[pbos-webrtc, 2015/07/22 11:05:27]

consider const char*

[terelius, 2015/07/23 15:54:01]

This is currently used in the unit test where the file name is obtained by
concatenating a few std::strings obtained from the gtest framework.

+                               RelEventStream* result);
+};
+
+}  // namespace webrtc
+
+#endif  // WEBRTC_VIDEO_RTC_EVENT_LOG_H_