webrtc/modules/audio_coding/codecs/ilbc/cb_update_best_index.h - Issue 1230693002: Update audio code to use size_t more correctly,

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/modules/audio_coding/codecs/ilbc/cb_update_best_index.h

Issue 1230693002: Update audio code to use size_t more correctly, (Closed) Base URL: https://chromium.googlesource.com/external/webrtc@master

Patch Set: Review comments Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: webrtc/modules/audio_coding/codecs/ilbc/cb_update_best_index.h

diff --git a/webrtc/modules/audio_coding/codecs/ilbc/cb_update_best_index.h b/webrtc/modules/audio_coding/codecs/ilbc/cb_update_best_index.h

index e8519d4118b9ffbf26932409d6abcd046b5c6130..a20fa38b2e51f0dae32d50779f27d6d891ff6f30 100644

--- a/webrtc/modules/audio_coding/codecs/ilbc/cb_update_best_index.h

+++ b/webrtc/modules/audio_coding/codecs/ilbc/cb_update_best_index.h

@@ -24,13 +24,13 @@

void WebRtcIlbcfix_CbUpdateBestIndex(

int32_t CritNew, /* (i) New Potentially best Criteria */

int16_t CritNewSh, /* (i) Shift value of above Criteria */

- int16_t IndexNew, /* (i) Index of new Criteria */

+ size_t IndexNew, /* (i) Index of new Criteria */

int32_t cDotNew, /* (i) Cross dot of new index */

int16_t invEnergyNew, /* (i) Inversed energy new index */

int16_t energyShiftNew, /* (i) Energy shifts of new index */

int32_t *CritMax, /* (i/o) Maximum Criteria (so far) */

int16_t *shTotMax, /* (i/o) Shifts of maximum criteria */

- int16_t *bestIndex, /* (i/o) Index that corresponds to

+ size_t *bestIndex, /* (i/o) Index that corresponds to

maximum criteria */

int16_t *bestGain); /* (i/o) Gain in Q14 that corresponds

to maximum criteria */