webrtc/common_audio/signal_processing/auto_correlation.c - Issue 1230503003: Update a ton of audio code to use size_t more correctly and in general reduce

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/common_audio/signal_processing/auto_correlation.c

Issue 1230503003: Update a ton of audio code to use size_t more correctly and in general reduce (Closed) Base URL: https://chromium.googlesource.com/external/webrtc@master

Patch Set: Resync Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « webrtc/common_audio/resampler/sinusoidal_linear_chirp_source.cc ('k') | webrtc/common_audio/signal_processing/complex_fft.c » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: webrtc/common_audio/signal_processing/auto_correlation.c

diff --git a/webrtc/common_audio/signal_processing/auto_correlation.c b/webrtc/common_audio/signal_processing/auto_correlation.c

index 405a08ecaff527f329e66abd49fbf2155d636e7c..8d6c879ca77986ffdc30a0a28a7c23f3e6bc4346 100644

--- a/webrtc/common_audio/signal_processing/auto_correlation.c

+++ b/webrtc/common_audio/signal_processing/auto_correlation.c

@@ -11,20 +11,18 @@

#include "webrtc/common_audio/signal_processing/include/signal_processing_library.h"

int WebRtcSpl_AutoCorrelation(const int16_t* in_vector,

- int in_vector_length,

- int order,

+ size_t in_vector_length,

+ size_t order,

int32_t* result,

int* scale) {

int32_t sum = 0;

- int i = 0, j = 0;

+ size_t i = 0, j = 0;

int16_t smax = 0;

int scaling = 0;

if (order > in_vector_length) {

/* Undefined */

return -1;

- } else if (order < 0) {

- order = in_vector_length;

}

// Find the maximum absolute value of the samples.

@@ -64,5 +62,5 @@ int WebRtcSpl_AutoCorrelation(const int16_t* in_vector,

}

*scale = scaling;

- return order + 1;

+ return (int)(order + 1);

}