webrtc/modules/audio_coding/codecs/ilbc/augmented_cb_corr.c - Issue 1230503003: Update a ton of audio code to use size_t more correctly and in general reduce

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/modules/audio_coding/codecs/ilbc/augmented_cb_corr.c

Issue 1230503003: Update a ton of audio code to use size_t more correctly and in general reduce (Closed) Base URL: https://chromium.googlesource.com/external/webrtc@master

Patch Set: Resync Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « webrtc/modules/audio_coding/codecs/ilbc/augmented_cb_corr.h ('k') | webrtc/modules/audio_coding/codecs/ilbc/cb_construct.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: webrtc/modules/audio_coding/codecs/ilbc/augmented_cb_corr.c

diff --git a/webrtc/modules/audio_coding/codecs/ilbc/augmented_cb_corr.c b/webrtc/modules/audio_coding/codecs/ilbc/augmented_cb_corr.c

index c24b4a6ac0cb48c146e09501056bfea34e65aa66..1a3735fc3db01effd4b63e40ce0433cab61bdf14 100644

--- a/webrtc/modules/audio_coding/codecs/ilbc/augmented_cb_corr.c

+++ b/webrtc/modules/audio_coding/codecs/ilbc/augmented_cb_corr.c

@@ -28,14 +28,14 @@ void WebRtcIlbcfix_AugmentedCbCorr(

int32_t *crossDot, /* (o) The cross correlation between

the target and the Augmented

vector */

- int16_t low, /* (i) Lag to start from (typically

+ size_t low, /* (i) Lag to start from (typically

20) */

- int16_t high, /* (i) Lag to end at (typically 39) */

+ size_t high, /* (i) Lag to end at (typically 39) */

int scale) /* (i) Scale factor to use for

the crossDot */

{

- int lagcount;

- int16_t ilow;

+ size_t lagcount;

+ size_t ilow;

int16_t *targetPtr;

int32_t *crossDotPtr;

int16_t *iSPtr=interpSamples;

@@ -46,7 +46,7 @@ void WebRtcIlbcfix_AugmentedCbCorr(

crossDotPtr=crossDot;

for (lagcount=low; lagcount<=high; lagcount++) {

- ilow = (int16_t) (lagcount-4);

+ ilow = lagcount - 4;

/* Compute dot product for the first (lagcount-4) samples */

(*crossDotPtr) = WebRtcSpl_DotProductWithScale(target, buffer-lagcount, ilow, scale);