webrtc/common_audio/signal_processing/resample_fractional.c - Issue 1230503003: Update a ton of audio code to use size_t more correctly and in general reduce

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/common_audio/signal_processing/resample_fractional.c

Issue 1230503003: Update a ton of audio code to use size_t more correctly and in general reduce (Closed) Base URL: https://chromium.googlesource.com/external/webrtc@master

Patch Set: Resync Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « webrtc/common_audio/signal_processing/resample_by_2_mips.c ('k') | webrtc/common_audio/signal_processing/signal_processing_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: webrtc/common_audio/signal_processing/resample_fractional.c

diff --git a/webrtc/common_audio/signal_processing/resample_fractional.c b/webrtc/common_audio/signal_processing/resample_fractional.c

index b8fb22bdf6c8d6dce22ad2db2da8f4278df5e788..6409fbac471cdd6064c01277f27fb6d6194f54da 100644

--- a/webrtc/common_audio/signal_processing/resample_fractional.c

+++ b/webrtc/common_audio/signal_processing/resample_fractional.c

@@ -41,7 +41,7 @@ static const int16_t kCoefficients44To32[4][9] = {

// output: int32_t (shifted 15 positions to the left, + offset 16384) :: size 2 * K

// K: number of blocks

-void WebRtcSpl_Resample48khzTo32khz(const int32_t *In, int32_t *Out, int32_t K)

+void WebRtcSpl_Resample48khzTo32khz(const int32_t *In, int32_t *Out, size_t K)

{

/////////////////////////////////////////////////////////////

// Filter operation:

@@ -49,7 +49,7 @@ void WebRtcSpl_Resample48khzTo32khz(const int32_t *In, int32_t *Out, int32_t K)

// Perform resampling (3 input samples -> 2 output samples);

// process in sub blocks of size 3 samples.

int32_t tmp;

- int32_t m;

+ size_t m;

for (m = 0; m < K; m++)

{

@@ -86,14 +86,14 @@ void WebRtcSpl_Resample48khzTo32khz(const int32_t *In, int32_t *Out, int32_t K)

// output: int32_t (shifted 15 positions to the left, + offset 16384) :: size 3 * K

// K: number of blocks

-void WebRtcSpl_Resample32khzTo24khz(const int32_t *In, int32_t *Out, int32_t K)

+void WebRtcSpl_Resample32khzTo24khz(const int32_t *In, int32_t *Out, size_t K)

{

/////////////////////////////////////////////////////////////

// Filter operation:

// Perform resampling (4 input samples -> 3 output samples);

// process in sub blocks of size 4 samples.

- int32_t m;

+ size_t m;

int32_t tmp;

for (m = 0; m < K; m++)

@@ -194,7 +194,7 @@ static void WebRtcSpl_ResampDotProduct(const int32_t *in1, const int32_t *in2,

// output: int32_t (shifted 15 positions to the left, + offset 16384) :: size 8 * K

// K: number of blocks

-void WebRtcSpl_Resample44khzTo32khz(const int32_t *In, int32_t *Out, int32_t K)

+void WebRtcSpl_Resample44khzTo32khz(const int32_t *In, int32_t *Out, size_t K)

{

/////////////////////////////////////////////////////////////

// Filter operation:

@@ -202,7 +202,7 @@ void WebRtcSpl_Resample44khzTo32khz(const int32_t *In, int32_t *Out, int32_t K)

// Perform resampling (11 input samples -> 8 output samples);

// process in sub blocks of size 11 samples.

int32_t tmp;

- int32_t m;

+ size_t m;

for (m = 0; m < K; m++)

{