Update a ton of audio code to use size_t more correctly and in general reduce

webrtc/modules/audio_coding/codecs/ilbc/do_plc.c

 /*
  *  Copyright (c) 2011 The WebRTC project authors. All Rights Reserved.
  *
  *  Use of this source code is governed by a BSD-style license
  *  that can be found in the LICENSE file in the root of the source
  *  tree. An additional intellectual property rights grant can be found
  *  in the file PATENTS.  All contributing project authors may
  *  be found in the AUTHORS file in the root of the source tree.
  */
 
@@ skipping 15 matching lines @@
  *  and LP parameters. If no packet loss, update state.
  *---------------------------------------------------------------*/
 
 void WebRtcIlbcfix_DoThePlc(
     int16_t *PLCresidual,  /* (o) concealed residual */
     int16_t *PLClpc,    /* (o) concealed LP parameters */
     int16_t PLI,     /* (i) packet loss indicator
                                                            0 - no PL, 1 = PL */
     int16_t *decresidual,  /* (i) decoded residual */
     int16_t *lpc,    /* (i) decoded LPC (only used for no PL) */
-    int16_t inlag,    /* (i) pitch lag */
+    size_t inlag,    /* (i) pitch lag */
     IlbcDecoder *iLBCdec_inst
     /* (i/o) decoder instance */
                             ){
-  int16_t i;
+  size_t i;
   int32_t cross, ener, cross_comp, ener_comp = 0;
   int32_t measure, maxMeasure, energy;
   int16_t max, crossSquareMax, crossSquare;
-  int16_t j, lag, tmp1, tmp2, randlag;
+  size_t j, lag, randlag;
+  int16_t tmp1, tmp2;
   int16_t shift1, shift2, shift3, shiftMax;
   int16_t scale3;
-  int16_t corrLen;
+  size_t corrLen;
   int32_t tmpW32, tmp2W32;
   int16_t use_gain;
   int16_t tot_gain;
   int16_t max_perSquare;
   int16_t scale1, scale2;
   int16_t totscale;
   int32_t nom;
   int16_t denom;
   int16_t pitchfact;
-  int16_t use_lag;
+  size_t use_lag;
   int ind;
   int16_t randvec[BLOCKL_MAX];
 
   /* Packet Loss */
   if (PLI == 1) {
 
     (*iLBCdec_inst).consPLICount += 1;
 
     /* if previous frame not lost,
        determine pitch pred. gain */
 
     if (iLBCdec_inst->prevPLI != 1) {
 
       /* Maximum 60 samples are correlated, preserve as high accuracy
          as possible without getting overflow */
       max = WebRtcSpl_MaxAbsValueW16((*iLBCdec_inst).prevResidual,
-                                     (int16_t)iLBCdec_inst->blockl);
+                                     iLBCdec_inst->blockl);
       scale3 = (WebRtcSpl_GetSizeInBits(max)<<1) - 25;
       if (scale3 < 0) {
         scale3 = 0;
       }
 
       /* Store scale for use when interpolating between the
        * concealment and the received packet */
       iLBCdec_inst->prevScale = scale3;
 
       /* Search around the previous lag +/-3 to find the
          best pitch period */
       lag = inlag - 3;
 
       /* Guard against getting outside the frame */
-      corrLen = WEBRTC_SPL_MIN(60, iLBCdec_inst->blockl-(inlag+3));
+      corrLen = (size_t)WEBRTC_SPL_MIN(60, iLBCdec_inst->blockl-(inlag+3));
 
       WebRtcIlbcfix_CompCorr( &cross, &ener,
                               iLBCdec_inst->prevResidual, lag, iLBCdec_inst->blockl, corrLen, scale3);
 
       /* Normalize and store cross^2 and the number of shifts */
       shiftMax = WebRtcSpl_GetSizeInBits(WEBRTC_SPL_ABS_W32(cross))-15;
       crossSquareMax = (int16_t)((
           (int16_t)WEBRTC_SPL_SHIFT_W32(cross, -shiftMax) *
           (int16_t)WEBRTC_SPL_SHIFT_W32(cross, -shiftMax)) >> 15);
 
@@ skipping 127 matching lines @@
       use_lag = 2*lag;
     }
 
     /* compute concealed residual */
     energy = 0;
 
     for (i=0; i<iLBCdec_inst->blockl; i++) {
 
       /* noise component -  52 < randlagFIX < 117 */
       iLBCdec_inst->seed = (int16_t)(iLBCdec_inst->seed * 31821 + 13849);
-      randlag = 53 + (int16_t)(iLBCdec_inst->seed & 63);
+      randlag = 53 + (iLBCdec_inst->seed & 63);
       if (randlag > i) {
         randvec[i] =
             iLBCdec_inst->prevResidual[iLBCdec_inst->blockl + i - randlag];
       } else {
         randvec[i] = iLBCdec_inst->prevResidual[i - randlag];
       }
 
       /* pitch repeatition component */
       if (use_lag > i) {
         PLCresidual[i] =
@@ skipping 47 matching lines @@
     iLBCdec_inst->consPLICount = 0;
   }
 
   /* update state */
   iLBCdec_inst->prevPLI = PLI;
   WEBRTC_SPL_MEMCPY_W16(iLBCdec_inst->prevLpc, PLClpc, (LPC_FILTERORDER+1));
   WEBRTC_SPL_MEMCPY_W16(iLBCdec_inst->prevResidual, PLCresidual, iLBCdec_inst->blockl);
 
   return;
 }