Update a ton of audio code to use size_t more correctly and in general reduce

webrtc/common_audio/signal_processing/min_max_operations_neon.c

 /*
  *  Copyright (c) 2014 The WebRTC project authors. All Rights Reserved.
  *
  *  Use of this source code is governed by a BSD-style license
  *  that can be found in the LICENSE file in the root of the source
  *  tree. An additional intellectual property rights grant can be found
  *  in the file PATENTS.  All contributing project authors may
  *  be found in the AUTHORS file in the root of the source tree.
  */
 
 #include <arm_neon.h>
 #include <stdlib.h>
 
 #include "webrtc/common_audio/signal_processing/include/signal_processing_library.h"
 
 // Maximum absolute value of word16 vector. C version for generic platforms.
-int16_t WebRtcSpl_MaxAbsValueW16Neon(const int16_t* vector, int length) {
+int16_t WebRtcSpl_MaxAbsValueW16Neon(const int16_t* vector, size_t length) {
   int absolute = 0, maximum = 0;
 
-  if (vector == NULL || length <= 0) {
+  if (vector == NULL || length == 0) {
     return -1;
   }
 
   const int16_t* p_start = vector;
-  int rest = length & 7;
+  size_t rest = length & 7;
   const int16_t* p_end = vector + length - rest;
 
   int16x8_t v;
   uint16x8_t max_qv;
   max_qv = vdupq_n_u16(0);
 
   while (p_start < p_end) {
     v = vld1q_s16(p_start);
     // Note vabs doesn't change the value of -32768.
     v = vabsq_s16(v);
@@ skipping 26 matching lines @@
   // Guard the case for abs(-32768).
   if (maximum > WEBRTC_SPL_WORD16_MAX) {
     maximum = WEBRTC_SPL_WORD16_MAX;
   }
 
   return (int16_t)maximum;
 }
 
 // Maximum absolute value of word32 vector. NEON intrinsics version for
 // ARM 32-bit/64-bit platforms.
-int32_t WebRtcSpl_MaxAbsValueW32Neon(const int32_t* vector, int length) {
+int32_t WebRtcSpl_MaxAbsValueW32Neon(const int32_t* vector, size_t length) {
   // Use uint32_t for the local variables, to accommodate the return value
   // of abs(0x80000000), which is 0x80000000.
 
   uint32_t absolute = 0, maximum = 0;
-  int i = 0;
-  int residual = length & 0x7;
+  size_t i = 0;
+  size_t residual = length & 0x7;
 
-  if (vector == NULL || length <= 0) {
+  if (vector == NULL || length == 0) {
     return -1;
   }
 
   const int32_t* p_start = vector;
   uint32x4_t max32x4_0 = vdupq_n_u32(0);
   uint32x4_t max32x4_1 = vdupq_n_u32(0);
 
   // First part, unroll the loop 8 times.
   for (i = 0; i < length - residual; i += 8) {
     int32x4_t in32x4_0 = vld1q_s32(p_start);
@@ skipping 28 matching lines @@
   }
 
   // Guard against the case for 0x80000000.
   maximum = WEBRTC_SPL_MIN(maximum, WEBRTC_SPL_WORD32_MAX);
 
   return (int32_t)maximum;
 }
 
 // Maximum value of word16 vector. NEON intrinsics version for
 // ARM 32-bit/64-bit platforms.
-int16_t WebRtcSpl_MaxValueW16Neon(const int16_t* vector, int length) {
+int16_t WebRtcSpl_MaxValueW16Neon(const int16_t* vector, size_t length) {
   int16_t maximum = WEBRTC_SPL_WORD16_MIN;
-  int i = 0;
-  int residual = length & 0x7;
+  size_t i = 0;
+  size_t residual = length & 0x7;
 
-  if (vector == NULL || length <= 0) {
+  if (vector == NULL || length == 0) {
     return maximum;
   }
 
   const int16_t* p_start = vector;
   int16x8_t max16x8 = vdupq_n_s16(WEBRTC_SPL_WORD16_MIN);
 
   // First part, unroll the loop 8 times.
   for (i = 0; i < length - residual; i += 8) {
     int16x8_t in16x8 = vld1q_s16(p_start);
     max16x8 = vmaxq_s16(max16x8, in16x8);
@@ skipping 14 matching lines @@
   for (i = residual; i > 0; i--) {
     if (*p_start > maximum)
       maximum = *p_start;
     p_start++;
   }
   return maximum;
 }
 
 // Maximum value of word32 vector. NEON intrinsics version for
 // ARM 32-bit/64-bit platforms.
-int32_t WebRtcSpl_MaxValueW32Neon(const int32_t* vector, int length) {
+int32_t WebRtcSpl_MaxValueW32Neon(const int32_t* vector, size_t length) {
   int32_t maximum = WEBRTC_SPL_WORD32_MIN;
-  int i = 0;
-  int residual = length & 0x7;
+  size_t i = 0;
+  size_t residual = length & 0x7;
 
-  if (vector == NULL || length <= 0) {
+  if (vector == NULL || length == 0) {
     return maximum;
   }
 
   const int32_t* p_start = vector;
   int32x4_t max32x4_0 = vdupq_n_s32(WEBRTC_SPL_WORD32_MIN);
   int32x4_t max32x4_1 = vdupq_n_s32(WEBRTC_SPL_WORD32_MIN);
 
   // First part, unroll the loop 8 times.
   for (i = 0; i < length - residual; i += 8) {
     int32x4_t in32x4_0 = vld1q_s32(p_start);
@@ skipping 18 matching lines @@
   for (i = residual; i > 0; i--) {
     if (*p_start > maximum)
       maximum = *p_start;
     p_start++;
   }
   return maximum;
 }
 
 // Minimum value of word16 vector. NEON intrinsics version for
 // ARM 32-bit/64-bit platforms.
-int16_t WebRtcSpl_MinValueW16Neon(const int16_t* vector, int length) {
+int16_t WebRtcSpl_MinValueW16Neon(const int16_t* vector, size_t length) {
   int16_t minimum = WEBRTC_SPL_WORD16_MAX;
-  int i = 0;
-  int residual = length & 0x7;
+  size_t i = 0;
+  size_t residual = length & 0x7;
 
-  if (vector == NULL || length <= 0) {
+  if (vector == NULL || length == 0) {
     return minimum;
   }
 
   const int16_t* p_start = vector;
   int16x8_t min16x8 = vdupq_n_s16(WEBRTC_SPL_WORD16_MAX);
 
   // First part, unroll the loop 8 times.
   for (i = 0; i < length - residual; i += 8) {
     int16x8_t in16x8 = vld1q_s16(p_start);
     min16x8 = vminq_s16(min16x8, in16x8);
@@ skipping 14 matching lines @@
   for (i = residual; i > 0; i--) {
     if (*p_start < minimum)
       minimum = *p_start;
     p_start++;
   }
   return minimum;
 }
 
 // Minimum value of word32 vector. NEON intrinsics version for
 // ARM 32-bit/64-bit platforms.
-int32_t WebRtcSpl_MinValueW32Neon(const int32_t* vector, int length) {
+int32_t WebRtcSpl_MinValueW32Neon(const int32_t* vector, size_t length) {
   int32_t minimum = WEBRTC_SPL_WORD32_MAX;
-  int i = 0;
-  int residual = length & 0x7;
+  size_t i = 0;
+  size_t residual = length & 0x7;
 
-  if (vector == NULL || length <= 0) {
+  if (vector == NULL || length == 0) {
     return minimum;
   }
 
   const int32_t* p_start = vector;
   int32x4_t min32x4_0 = vdupq_n_s32(WEBRTC_SPL_WORD32_MAX);
   int32x4_t min32x4_1 = vdupq_n_s32(WEBRTC_SPL_WORD32_MAX);
 
   // First part, unroll the loop 8 times.
   for (i = 0; i < length - residual; i += 8) {
     int32x4_t in32x4_0 = vld1q_s32(p_start);
@@ skipping 16 matching lines @@
 
   // Second part, do the remaining iterations (if any).
   for (i = residual; i > 0; i--) {
     if (*p_start < minimum)
       minimum = *p_start;
     p_start++;
   }
   return minimum;
 }