Update a ton of audio code to use size_t more correctly and in general reduce

webrtc/common_audio/signal_processing/min_max_operations.c

 /*
  *  Copyright (c) 2012 The WebRTC project authors. All Rights Reserved.
  *
  *  Use of this source code is governed by a BSD-style license
  *  that can be found in the LICENSE file in the root of the source
  *  tree. An additional intellectual property rights grant can be found
  *  in the file PATENTS.  All contributing project authors may
  *  be found in the AUTHORS file in the root of the source tree.
  */
 
@@ skipping 15 matching lines @@
 
 #include "webrtc/common_audio/signal_processing/include/signal_processing_library.h"
 
 #include <stdlib.h>
 
 // TODO(bjorn/kma): Consolidate function pairs (e.g. combine
 //   WebRtcSpl_MaxAbsValueW16C and WebRtcSpl_MaxAbsIndexW16 into a single one.)
 // TODO(kma): Move the next six functions into min_max_operations_c.c.
 
 // Maximum absolute value of word16 vector. C version for generic platforms.
-int16_t WebRtcSpl_MaxAbsValueW16C(const int16_t* vector, int length) {
-  int i = 0, absolute = 0, maximum = 0;
+int16_t WebRtcSpl_MaxAbsValueW16C(const int16_t* vector, size_t length) {
+  size_t i = 0;
+  int absolute = 0, maximum = 0;
 
-  if (vector == NULL || length <= 0) {
+  if (vector == NULL || length == 0) {
     return -1;
   }
 
   for (i = 0; i < length; i++) {
     absolute = abs((int)vector[i]);
 
     if (absolute > maximum) {
       maximum = absolute;
     }
   }
 
   // Guard the case for abs(-32768).
   if (maximum > WEBRTC_SPL_WORD16_MAX) {
     maximum = WEBRTC_SPL_WORD16_MAX;
   }
 
   return (int16_t)maximum;
 }
 
 // Maximum absolute value of word32 vector. C version for generic platforms.
-int32_t WebRtcSpl_MaxAbsValueW32C(const int32_t* vector, int length) {
+int32_t WebRtcSpl_MaxAbsValueW32C(const int32_t* vector, size_t length) {
   // Use uint32_t for the local variables, to accommodate the return value
   // of abs(0x80000000), which is 0x80000000.
 
   uint32_t absolute = 0, maximum = 0;
-  int i = 0;
+  size_t i = 0;
 
-  if (vector == NULL || length <= 0) {
+  if (vector == NULL || length == 0) {
     return -1;
   }
 
   for (i = 0; i < length; i++) {
     absolute = abs((int)vector[i]);
     if (absolute > maximum) {
       maximum = absolute;
     }
   }
 
   maximum = WEBRTC_SPL_MIN(maximum, WEBRTC_SPL_WORD32_MAX);
 
   return (int32_t)maximum;
 }
 
 // Maximum value of word16 vector. C version for generic platforms.
-int16_t WebRtcSpl_MaxValueW16C(const int16_t* vector, int length) {
+int16_t WebRtcSpl_MaxValueW16C(const int16_t* vector, size_t length) {
   int16_t maximum = WEBRTC_SPL_WORD16_MIN;
-  int i = 0;
+  size_t i = 0;
 
-  if (vector == NULL || length <= 0) {
+  if (vector == NULL || length == 0) {
     return maximum;
   }
 
   for (i = 0; i < length; i++) {
     if (vector[i] > maximum)
       maximum = vector[i];
   }
   return maximum;
 }
 
 // Maximum value of word32 vector. C version for generic platforms.
-int32_t WebRtcSpl_MaxValueW32C(const int32_t* vector, int length) {
+int32_t WebRtcSpl_MaxValueW32C(const int32_t* vector, size_t length) {
   int32_t maximum = WEBRTC_SPL_WORD32_MIN;
-  int i = 0;
+  size_t i = 0;
 
-  if (vector == NULL || length <= 0) {
+  if (vector == NULL || length == 0) {
     return maximum;
   }
 
   for (i = 0; i < length; i++) {
     if (vector[i] > maximum)
       maximum = vector[i];
   }
   return maximum;
 }
 
 // Minimum value of word16 vector. C version for generic platforms.
-int16_t WebRtcSpl_MinValueW16C(const int16_t* vector, int length) {
+int16_t WebRtcSpl_MinValueW16C(const int16_t* vector, size_t length) {
   int16_t minimum = WEBRTC_SPL_WORD16_MAX;
-  int i = 0;
+  size_t i = 0;
 
-  if (vector == NULL || length <= 0) {
+  if (vector == NULL || length == 0) {
     return minimum;
   }
 
   for (i = 0; i < length; i++) {
     if (vector[i] < minimum)
       minimum = vector[i];
   }
   return minimum;
 }
 
 // Minimum value of word32 vector. C version for generic platforms.
-int32_t WebRtcSpl_MinValueW32C(const int32_t* vector, int length) {
+int32_t WebRtcSpl_MinValueW32C(const int32_t* vector, size_t length) {
   int32_t minimum = WEBRTC_SPL_WORD32_MAX;
-  int i = 0;
+  size_t i = 0;
 
-  if (vector == NULL || length <= 0) {
+  if (vector == NULL || length == 0) {
     return minimum;
   }
 
   for (i = 0; i < length; i++) {
     if (vector[i] < minimum)
       minimum = vector[i];
   }
   return minimum;
 }
 
 // Index of maximum absolute value in a word16 vector.
-int WebRtcSpl_MaxAbsIndexW16(const int16_t* vector, int length) {
+int WebRtcSpl_MaxAbsIndexW16(const int16_t* vector, size_t length) {
   // Use type int for local variables, to accomodate the value of abs(-32768).
 
-  int i = 0, absolute = 0, maximum = 0, index = 0;
+  size_t i = 0, index = 0;
+  int absolute = 0, maximum = 0;
 
-  if (vector == NULL || length <= 0) {
+  if (vector == NULL || length == 0) {
     return -1;
   }
 
   for (i = 0; i < length; i++) {
     absolute = abs((int)vector[i]);
 
     if (absolute > maximum) {
       maximum = absolute;
       index = i;
     }
   }
 
-  return index;
+  return (int)index;
 }
 
 // Index of maximum value in a word16 vector.
-int WebRtcSpl_MaxIndexW16(const int16_t* vector, int length) {
-  int i = 0, index = 0;
+int WebRtcSpl_MaxIndexW16(const int16_t* vector, size_t length) {
+  size_t i = 0, index = 0;
   int16_t maximum = WEBRTC_SPL_WORD16_MIN;
 
-  if (vector == NULL || length <= 0) {
+  if (vector == NULL || length == 0) {
     return -1;
   }
 
   for (i = 0; i < length; i++) {
     if (vector[i] > maximum) {
       maximum = vector[i];
       index = i;
     }
   }
 
-  return index;
+  return (int)index;
 }
 
 // Index of maximum value in a word32 vector.
-int WebRtcSpl_MaxIndexW32(const int32_t* vector, int length) {
-  int i = 0, index = 0;
+int WebRtcSpl_MaxIndexW32(const int32_t* vector, size_t length) {
+  size_t i = 0, index = 0;
   int32_t maximum = WEBRTC_SPL_WORD32_MIN;
 
-  if (vector == NULL || length <= 0) {
+  if (vector == NULL || length == 0) {
     return -1;
   }
 
   for (i = 0; i < length; i++) {
     if (vector[i] > maximum) {
       maximum = vector[i];
       index = i;
     }
   }
 
-  return index;
+  return (int)index;
 }
 
 // Index of minimum value in a word16 vector.
-int WebRtcSpl_MinIndexW16(const int16_t* vector, int length) {
-  int i = 0, index = 0;
+int WebRtcSpl_MinIndexW16(const int16_t* vector, size_t length) {
+  size_t i = 0, index = 0;
   int16_t minimum = WEBRTC_SPL_WORD16_MAX;
 
-  if (vector == NULL || length <= 0) {
+  if (vector == NULL || length == 0) {
     return -1;
   }
 
   for (i = 0; i < length; i++) {
     if (vector[i] < minimum) {
       minimum = vector[i];
       index = i;
     }
   }
 
-  return index;
+  return (int)index;
 }
 
 // Index of minimum value in a word32 vector.
-int WebRtcSpl_MinIndexW32(const int32_t* vector, int length) {
-  int i = 0, index = 0;
+int WebRtcSpl_MinIndexW32(const int32_t* vector, size_t length) {
+  size_t i = 0, index = 0;
   int32_t minimum = WEBRTC_SPL_WORD32_MAX;
 
-  if (vector == NULL || length <= 0) {
+  if (vector == NULL || length == 0) {
     return -1;
   }
 
   for (i = 0; i < length; i++) {
     if (vector[i] < minimum) {
       minimum = vector[i];
       index = i;
     }
   }
 
-  return index;
+  return (int)index;
 }