Issue 1230383003: Revert of Fix simulator issue where chokes didn't apply to non-congested packets.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1230383003: Revert of Fix simulator issue where chokes didn't apply to non-congested packets. (Closed)

Created:
5 years, 5 months ago by stefan-webrtc

Modified:
5 years, 5 months ago

Reviewers:
magalhaesc1, magalhaesc

CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, mflodman

Base URL:
https://chromium.googlesource.com/external/webrtc.git@master

Target Ref:
refs/pending/heads/master

Project:
webrtc

Visibility:
Public.

Revert of Fix simulator issue where chokes didn't apply to non-congested packets. (patchset #2 id:20001 of https://codereview.webrtc.org/1233853002/) Reason for revert: Breaks bots. Original issue's description: > Fix simulator issue where chokes didn't apply to non-congested packets. > > R=magalhaesc@google.com > > Committed: https://chromium.googlesource.com/external/webrtc/+/662ae00efaa71fbb964eba44b60de4567fc36a73 TBR=magalhaesc@webrtc.org,magalhaesc@google.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://crrev.com/45d1fdee9d6eeffd51ee39c4d40028234807b81e Cr-Commit-Position: refs/heads/master@{#9571}

Created: 5 years, 5 months ago

(Patch set is too large to download)

	Unified diffs	Side-by-side diffs	Stats (+10 lines, -35 lines)			Patch
M	webrtc/modules/modules.gyp	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	webrtc/modules/remote_bitrate_estimator/remote_bitrate_estimator.gypi	View	2 chunks	+2 lines, -0 lines	0 comments	Download
M	webrtc/modules/remote_bitrate_estimator/test/bwe_test_framework.cc	View	1 chunk	+3 lines, -2 lines	0 comments	Download
M	webrtc/modules/remote_bitrate_estimator/test/bwe_test_framework_unittest.cc	View	3 chunks	+5 lines, -31 lines	0 comments	Download

Total messages: 4 (0 generated)

stefan-webrtc

Created Revert of Fix simulator issue where chokes didn't apply to non-congested packets.

5 years, 5 months ago (2015-07-13 15:37:26 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1230383003/1

5 years, 5 months ago (2015-07-13 15:37:40 UTC) #2

commit-bot: I haz the power

5 years, 5 months ago (2015-07-13 15:38:07 UTC) #4

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/45d1fdee9d6eeffd51ee39c4d40028234807b81e
Cr-Commit-Position: refs/heads/master@{#9571}