webrtc/modules/audio_processing/include/audio_processing.h - Issue 1229443003: audio_processing: Adds two UMA histograms logging delay jumps in AEC

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/modules/audio_processing/include/audio_processing.h

Issue 1229443003: audio_processing: Adds two UMA histograms logging delay jumps in AEC (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master

Patch Set: Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « webrtc/modules/audio_processing/audio_processing_impl.cc ('k') | webrtc/modules/audio_processing/include/mock_audio_processing.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: webrtc/modules/audio_processing/include/audio_processing.h

diff --git a/webrtc/modules/audio_processing/include/audio_processing.h b/webrtc/modules/audio_processing/include/audio_processing.h

index 9affbdd107c784dc38278222ee9540770e967e74..f657a1c436494d5565c65a2d866480015ba0109d 100644

--- a/webrtc/modules/audio_processing/include/audio_processing.h

+++ b/webrtc/modules/audio_processing/include/audio_processing.h

@@ -378,6 +378,10 @@ class AudioProcessing {

// cannot be resumed in the same file (without overwriting it).

virtual int StopDebugRecording() = 0;

+ // Updates UMA histograms at end of a call. This will also reset the histogram

+ // specific member variables.

bjornv1 2015/07/07 07:31:35 I'll change the description such that this functio

+ virtual void UpdateHistogramsOnCallEnd() = 0;

// These provide access to the component interfaces and should never return

// NULL. The pointers will be valid for the lifetime of the APM instance.

// The memory for these objects is entirely managed internally.