Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(257)

Issue 1229443002: Use strcmp instead of == operator for c.name and name to find appropriate classes for WebRtcAudio*.… (Closed)

Created:
5 years, 5 months ago by sophiechang-webrtc
Modified:
5 years, 5 months ago
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Use strcmp instead of == operator for c.name and name to find appropriate classes for WebRtcAudio*.java . BUG= Committed: https://crrev.com/f935bcc2f76233630f2dfd3c33569d4fe14de55f Cr-Commit-Position: refs/heads/master@{#9543}

Patch Set 1 #

Patch Set 2 : Add space after comma in strcmp #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M webrtc/modules/utility/source/jvm_android.cc View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (4 generated)
sophiechang-webrtc
5 years, 5 months ago (2015-07-06 22:29:42 UTC) #2
åsapersson
lgtm
5 years, 5 months ago (2015-07-07 06:48:43 UTC) #4
tommi
lgtm
5 years, 5 months ago (2015-07-07 07:31:40 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1229443002/20001
5 years, 5 months ago (2015-07-07 07:31:55 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 5 months ago (2015-07-07 08:10:20 UTC) #9
commit-bot: I haz the power
5 years, 5 months ago (2015-07-07 08:10:32 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/f935bcc2f76233630f2dfd3c33569d4fe14de55f
Cr-Commit-Position: refs/heads/master@{#9543}

Powered by Google App Engine
This is Rietveld 408576698