Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(114)

Issue 1228853004: Reduce locking in overuse frame detector now that (as of r9508) the observer_ and options_ can only (Closed)

Created:
5 years, 5 months ago by åsapersson
Modified:
5 years, 3 months ago
Reviewers:
pbos-webrtc
CC:
webrtc-reviews_webrtc.org, yujie_mao (webrtc), stefan-webrtc, tterriberry_mozilla.com, andresp, perkj_webrtc, mflodman
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Reduce locking in overuse frame detector now that (as of r9508) the observer_ and options_ can only be set at construction time. E.g. no lock is any longer held while doing the callback. BUG= Committed: https://crrev.com/74d85e19ae118ed1c98ac45284b2295134633220 Cr-Commit-Position: refs/heads/master@{#10043}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : rebase #

Patch Set 4 : #

Patch Set 5 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -33 lines) Patch
M webrtc/video_engine/overuse_frame_detector.h View 1 2 3 4 3 chunks +9 lines, -14 lines 0 comments Download
M webrtc/video_engine/overuse_frame_detector.cc View 1 2 3 5 chunks +27 lines, -19 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
åsapersson
5 years, 3 months ago (2015-09-23 13:02:59 UTC) #3
pbos-webrtc
lgtm
5 years, 3 months ago (2015-09-23 13:36:56 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1228853004/90001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1228853004/90001
5 years, 3 months ago (2015-09-24 07:35:16 UTC) #6
commit-bot: I haz the power
Committed patchset #5 (id:90001)
5 years, 3 months ago (2015-09-24 07:53:37 UTC) #7
commit-bot: I haz the power
5 years, 3 months ago (2015-09-24 07:53:46 UTC) #8
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/74d85e19ae118ed1c98ac45284b2295134633220
Cr-Commit-Position: refs/heads/master@{#10043}

Powered by Google App Engine
This is Rietveld 408576698