webrtc/modules/audio_coding/neteq/dtmf_tone_generator_unittest.cc - Issue 1228843002: Update audio code to use size_t more correctly,

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/modules/audio_coding/neteq/dtmf_tone_generator_unittest.cc

Issue 1228843002: Update audio code to use size_t more correctly, (Closed) Base URL: https://chromium.googlesource.com/external/webrtc@master

Patch Set: Review comments Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: webrtc/modules/audio_coding/neteq/dtmf_tone_generator_unittest.cc

diff --git a/webrtc/modules/audio_coding/neteq/dtmf_tone_generator_unittest.cc b/webrtc/modules/audio_coding/neteq/dtmf_tone_generator_unittest.cc

index ccd7fa606f117262af46195180d06ecc56820e0c..a55e6c90288625d04e39f0675de546ab5c54723c 100644

--- a/webrtc/modules/audio_coding/neteq/dtmf_tone_generator_unittest.cc

+++ b/webrtc/modules/audio_coding/neteq/dtmf_tone_generator_unittest.cc

@@ -171,8 +171,6 @@ TEST(DtmfToneGenerator, TestErrors) {

// Initialize with valid parameters.

ASSERT_EQ(0, tone_gen.Init(fs, event, attenuation));

EXPECT_TRUE(tone_gen.initialized());

- // Negative number of samples.

- EXPECT_EQ(DtmfToneGenerator::kParameterError, tone_gen.Generate(-1, &signal));

// NULL pointer to destination.

EXPECT_EQ(DtmfToneGenerator::kParameterError,

tone_gen.Generate(kNumSamples, NULL));