Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(196)

Side by Side Diff: webrtc/modules/audio_coding/neteq/decision_logic.h

Issue 1228843002: Update audio code to use size_t more correctly, (Closed) Base URL: https://chromium.googlesource.com/external/webrtc@master
Patch Set: Review comments Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (c) 2013 The WebRTC project authors. All Rights Reserved. 2 * Copyright (c) 2013 The WebRTC project authors. All Rights Reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 10
(...skipping 16 matching lines...) Expand all
27 class SyncBuffer; 27 class SyncBuffer;
28 struct RTPHeader; 28 struct RTPHeader;
29 29
30 // This is the base class for the decision tree implementations. Derived classes 30 // This is the base class for the decision tree implementations. Derived classes
31 // must implement the method GetDecisionSpecialized(). 31 // must implement the method GetDecisionSpecialized().
32 class DecisionLogic { 32 class DecisionLogic {
33 public: 33 public:
34 // Static factory function which creates different types of objects depending 34 // Static factory function which creates different types of objects depending
35 // on the |playout_mode|. 35 // on the |playout_mode|.
36 static DecisionLogic* Create(int fs_hz, 36 static DecisionLogic* Create(int fs_hz,
37 int output_size_samples, 37 size_t output_size_samples,
38 NetEqPlayoutMode playout_mode, 38 NetEqPlayoutMode playout_mode,
39 DecoderDatabase* decoder_database, 39 DecoderDatabase* decoder_database,
40 const PacketBuffer& packet_buffer, 40 const PacketBuffer& packet_buffer,
41 DelayManager* delay_manager, 41 DelayManager* delay_manager,
42 BufferLevelFilter* buffer_level_filter); 42 BufferLevelFilter* buffer_level_filter);
43 43
44 // Constructor. 44 // Constructor.
45 DecisionLogic(int fs_hz, 45 DecisionLogic(int fs_hz,
46 int output_size_samples, 46 size_t output_size_samples,
47 NetEqPlayoutMode playout_mode, 47 NetEqPlayoutMode playout_mode,
48 DecoderDatabase* decoder_database, 48 DecoderDatabase* decoder_database,
49 const PacketBuffer& packet_buffer, 49 const PacketBuffer& packet_buffer,
50 DelayManager* delay_manager, 50 DelayManager* delay_manager,
51 BufferLevelFilter* buffer_level_filter); 51 BufferLevelFilter* buffer_level_filter);
52 52
53 // Destructor. 53 // Destructor.
54 virtual ~DecisionLogic() {} 54 virtual ~DecisionLogic() {}
55 55
56 // Resets object to a clean state. 56 // Resets object to a clean state.
57 void Reset(); 57 void Reset();
58 58
59 // Resets parts of the state. Typically done when switching codecs. 59 // Resets parts of the state. Typically done when switching codecs.
60 void SoftReset(); 60 void SoftReset();
61 61
62 // Sets the sample rate and the output block size. 62 // Sets the sample rate and the output block size.
63 void SetSampleRate(int fs_hz, int output_size_samples); 63 void SetSampleRate(int fs_hz, size_t output_size_samples);
64 64
65 // Returns the operation that should be done next. |sync_buffer| and |expand| 65 // Returns the operation that should be done next. |sync_buffer| and |expand|
66 // are provided for reference. |decoder_frame_length| is the number of samples 66 // are provided for reference. |decoder_frame_length| is the number of samples
67 // obtained from the last decoded frame. If there is a packet available, the 67 // obtained from the last decoded frame. If there is a packet available, the
68 // packet header should be supplied in |packet_header|; otherwise it should 68 // packet header should be supplied in |packet_header|; otherwise it should
69 // be NULL. The mode resulting form the last call to NetEqImpl::GetAudio is 69 // be NULL. The mode resulting form the last call to NetEqImpl::GetAudio is
70 // supplied in |prev_mode|. If there is a DTMF event to play, |play_dtmf| 70 // supplied in |prev_mode|. If there is a DTMF event to play, |play_dtmf|
71 // should be set to true. The output variable |reset_decoder| will be set to 71 // should be set to true. The output variable |reset_decoder| will be set to
72 // true if a reset is required; otherwise it is left unchanged (i.e., it can 72 // true if a reset is required; otherwise it is left unchanged (i.e., it can
73 // remain true if it was true before the call). 73 // remain true if it was true before the call).
74 // This method end with calling GetDecisionSpecialized to get the actual 74 // This method end with calling GetDecisionSpecialized to get the actual
75 // return value. 75 // return value.
76 Operations GetDecision(const SyncBuffer& sync_buffer, 76 Operations GetDecision(const SyncBuffer& sync_buffer,
77 const Expand& expand, 77 const Expand& expand,
78 int decoder_frame_length, 78 size_t decoder_frame_length,
79 const RTPHeader* packet_header, 79 const RTPHeader* packet_header,
80 Modes prev_mode, 80 Modes prev_mode,
81 bool play_dtmf, 81 bool play_dtmf,
82 bool* reset_decoder); 82 bool* reset_decoder);
83 83
84 // These methods test the |cng_state_| for different conditions. 84 // These methods test the |cng_state_| for different conditions.
85 bool CngRfc3389On() const { return cng_state_ == kCngRfc3389On; } 85 bool CngRfc3389On() const { return cng_state_ == kCngRfc3389On; }
86 bool CngOff() const { return cng_state_ == kCngOff; } 86 bool CngOff() const { return cng_state_ == kCngOff; }
87 87
88 // Resets the |cng_state_| to kCngOff. 88 // Resets the |cng_state_| to kCngOff.
89 void SetCngOff() { cng_state_ = kCngOff; } 89 void SetCngOff() { cng_state_ = kCngOff; }
90 90
91 // Reports back to DecisionLogic whether the decision to do expand remains or 91 // Reports back to DecisionLogic whether the decision to do expand remains or
92 // not. Note that this is necessary, since an expand decision can be changed 92 // not. Note that this is necessary, since an expand decision can be changed
93 // to kNormal in NetEqImpl::GetDecision if there is still enough data in the 93 // to kNormal in NetEqImpl::GetDecision if there is still enough data in the
94 // sync buffer. 94 // sync buffer.
95 virtual void ExpandDecision(Operations operation); 95 virtual void ExpandDecision(Operations operation);
96 96
97 // Adds |value| to |sample_memory_|. 97 // Adds |value| to |sample_memory_|.
98 void AddSampleMemory(int32_t value) { 98 void AddSampleMemory(int32_t value) {
99 sample_memory_ += value; 99 sample_memory_ += value;
100 } 100 }
101 101
102 // Accessors and mutators. 102 // Accessors and mutators.
103 void set_sample_memory(int32_t value) { sample_memory_ = value; } 103 void set_sample_memory(int32_t value) { sample_memory_ = value; }
104 int generated_noise_samples() const { return generated_noise_samples_; } 104 size_t generated_noise_samples() const { return generated_noise_samples_; }
105 void set_generated_noise_samples(int value) { 105 void set_generated_noise_samples(size_t value) {
106 generated_noise_samples_ = value; 106 generated_noise_samples_ = value;
107 } 107 }
108 int packet_length_samples() const { return packet_length_samples_; } 108 size_t packet_length_samples() const { return packet_length_samples_; }
109 void set_packet_length_samples(int value) { 109 void set_packet_length_samples(size_t value) {
110 packet_length_samples_ = value; 110 packet_length_samples_ = value;
111 } 111 }
112 void set_prev_time_scale(bool value) { prev_time_scale_ = value; } 112 void set_prev_time_scale(bool value) { prev_time_scale_ = value; }
113 NetEqPlayoutMode playout_mode() const { return playout_mode_; } 113 NetEqPlayoutMode playout_mode() const { return playout_mode_; }
114 114
115 protected: 115 protected:
116 // The value 6 sets maximum time-stretch rate to about 100 ms/s. 116 // The value 6 sets maximum time-stretch rate to about 100 ms/s.
117 static const int kMinTimescaleInterval = 6; 117 static const int kMinTimescaleInterval = 6;
118 118
119 enum CngState { 119 enum CngState {
120 kCngOff, 120 kCngOff,
121 kCngRfc3389On, 121 kCngRfc3389On,
122 kCngInternalOn 122 kCngInternalOn
123 }; 123 };
124 124
125 // Returns the operation that should be done next. |sync_buffer| and |expand| 125 // Returns the operation that should be done next. |sync_buffer| and |expand|
126 // are provided for reference. |decoder_frame_length| is the number of samples 126 // are provided for reference. |decoder_frame_length| is the number of samples
127 // obtained from the last decoded frame. If there is a packet available, the 127 // obtained from the last decoded frame. If there is a packet available, the
128 // packet header should be supplied in |packet_header|; otherwise it should 128 // packet header should be supplied in |packet_header|; otherwise it should
129 // be NULL. The mode resulting form the last call to NetEqImpl::GetAudio is 129 // be NULL. The mode resulting form the last call to NetEqImpl::GetAudio is
130 // supplied in |prev_mode|. If there is a DTMF event to play, |play_dtmf| 130 // supplied in |prev_mode|. If there is a DTMF event to play, |play_dtmf|
131 // should be set to true. The output variable |reset_decoder| will be set to 131 // should be set to true. The output variable |reset_decoder| will be set to
132 // true if a reset is required; otherwise it is left unchanged (i.e., it can 132 // true if a reset is required; otherwise it is left unchanged (i.e., it can
133 // remain true if it was true before the call). 133 // remain true if it was true before the call).
134 // Should be implemented by derived classes. 134 // Should be implemented by derived classes.
135 virtual Operations GetDecisionSpecialized(const SyncBuffer& sync_buffer, 135 virtual Operations GetDecisionSpecialized(const SyncBuffer& sync_buffer,
136 const Expand& expand, 136 const Expand& expand,
137 int decoder_frame_length, 137 size_t decoder_frame_length,
138 const RTPHeader* packet_header, 138 const RTPHeader* packet_header,
139 Modes prev_mode, 139 Modes prev_mode,
140 bool play_dtmf, 140 bool play_dtmf,
141 bool* reset_decoder) = 0; 141 bool* reset_decoder) = 0;
142 142
143 // Updates the |buffer_level_filter_| with the current buffer level 143 // Updates the |buffer_level_filter_| with the current buffer level
144 // |buffer_size_packets|. 144 // |buffer_size_packets|.
145 void FilterBufferLevel(int buffer_size_packets, Modes prev_mode); 145 void FilterBufferLevel(size_t buffer_size_packets, Modes prev_mode);
146 146
147 DecoderDatabase* decoder_database_; 147 DecoderDatabase* decoder_database_;
148 const PacketBuffer& packet_buffer_; 148 const PacketBuffer& packet_buffer_;
149 DelayManager* delay_manager_; 149 DelayManager* delay_manager_;
150 BufferLevelFilter* buffer_level_filter_; 150 BufferLevelFilter* buffer_level_filter_;
151 int fs_mult_; 151 int fs_mult_;
152 int output_size_samples_; 152 size_t output_size_samples_;
153 CngState cng_state_; // Remember if comfort noise is interrupted by other 153 CngState cng_state_; // Remember if comfort noise is interrupted by other
154 // event (e.g., DTMF). 154 // event (e.g., DTMF).
155 int generated_noise_samples_; 155 size_t generated_noise_samples_;
156 int packet_length_samples_; 156 size_t packet_length_samples_;
157 int sample_memory_; 157 int sample_memory_;
158 bool prev_time_scale_; 158 bool prev_time_scale_;
159 int timescale_hold_off_; 159 int timescale_hold_off_;
160 int num_consecutive_expands_; 160 int num_consecutive_expands_;
161 const NetEqPlayoutMode playout_mode_; 161 const NetEqPlayoutMode playout_mode_;
162 162
163 private: 163 private:
164 DISALLOW_COPY_AND_ASSIGN(DecisionLogic); 164 DISALLOW_COPY_AND_ASSIGN(DecisionLogic);
165 }; 165 };
166 166
167 } // namespace webrtc 167 } // namespace webrtc
168 #endif // WEBRTC_MODULES_AUDIO_CODING_NETEQ_DECISION_LOGIC_H_ 168 #endif // WEBRTC_MODULES_AUDIO_CODING_NETEQ_DECISION_LOGIC_H_
OLDNEW
« no previous file with comments | « webrtc/modules/audio_coding/neteq/comfort_noise.cc ('k') | webrtc/modules/audio_coding/neteq/decision_logic.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698