webrtc/modules/audio_device/dummy/file_audio_device.cc - Issue 1228823003: Update audio code to use size_t more correctly, webrtc/modules/audio_device/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/modules/audio_device/dummy/file_audio_device.cc

Issue 1228823003: Update audio code to use size_t more correctly, webrtc/modules/audio_device/ (Closed) Base URL: https://chromium.googlesource.com/external/webrtc@master

Patch Set: Checkpoint Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « webrtc/modules/audio_device/dummy/file_audio_device.h ('k') | webrtc/modules/audio_device/include/audio_device_defines.h » ('j') | webrtc/modules/audio_device/include/audio_device_defines.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: webrtc/modules/audio_device/dummy/file_audio_device.cc

diff --git a/webrtc/modules/audio_device/dummy/file_audio_device.cc b/webrtc/modules/audio_device/dummy/file_audio_device.cc

index 3de5344a8f151a81540e57ca2bc7b25b5305c131..fa00459362fb6b56ad367b3ec6e01cab22f2d7bd 100644

--- a/webrtc/modules/audio_device/dummy/file_audio_device.cc

+++ b/webrtc/modules/audio_device/dummy/file_audio_device.cc

@@ -172,7 +172,7 @@ int32_t FileAudioDevice::InitRecording() {

return -1;

}

- _recordingFramesIn10MS = static_cast<uint32_t>(kRecordingFixedSampleRate/100);

+ _recordingFramesIn10MS = static_cast<size_t>(kRecordingFixedSampleRate/100);

henrika_webrtc 2015/07/24 10:43:04 nit, (kRecordingFixedSampleRate / 100)

Peter Kasting 2015/07/27 23:28:02 Done.

if (_ptrAudioBuffer) {

_ptrAudioBuffer->SetRecordingSampleRate(kRecordingFixedSampleRate);

@@ -190,7 +190,7 @@ int32_t FileAudioDevice::StartPlayout() {

return 0;

}

- _playoutFramesIn10MS = static_cast<uint32_t>(kPlayoutFixedSampleRate/100);

+ _playoutFramesIn10MS = static_cast<size_t>(kPlayoutFixedSampleRate / 100);

_playing = true;

_playoutFramesLeft = 0;