Update audio code to use size_t more correctly, webrtc/modules/audio_device/
portion.
This is a piece of https://codereview.webrtc.org/1230503003 , split out to a
separate change to make reviewing easier.
BUG=chromium:81439
TEST=none
5 years, 4 months ago
(2015-07-27 23:28:02 UTC)
#5
https://codereview.webrtc.org/1228823003/diff/40001/webrtc/modules/audio_devi...
File webrtc/modules/audio_device/dummy/file_audio_device.cc (right):
https://codereview.webrtc.org/1228823003/diff/40001/webrtc/modules/audio_devi...
webrtc/modules/audio_device/dummy/file_audio_device.cc:175:
_recordingFramesIn10MS = static_cast<size_t>(kRecordingFixedSampleRate/100);
On 2015/07/24 10:43:04, henrika_webrtc wrote:
> nit, (kRecordingFixedSampleRate / 100)
Done.
https://codereview.webrtc.org/1228823003/diff/40001/webrtc/modules/audio_devi...
File webrtc/modules/audio_device/include/audio_device_defines.h (right):
https://codereview.webrtc.org/1228823003/diff/40001/webrtc/modules/audio_devi...
webrtc/modules/audio_device/include/audio_device_defines.h:188: size_t
frames_per_10ms_buffer_;
On 2015/07/24 10:43:04, henrika_webrtc wrote:
> I have asked a similar question before but it is not clear to me why
> frames_per_10ms_buffer_ should be size_t but not frames_per_buffer_. What is
the
> difference?
The answer is that fixing |frames_per_10ms_buffer_| was required to get the rest
of my CL to compile whereas fixing |frames_per_buffer_| wasn't.
In principle, both should be size_t. This just doesn't bother to convert the
other variable yet. I can stick that in my set of things to convert in the next
pass.
Issue 1228823003: Update audio code to use size_t more correctly, webrtc/modules/audio_device/
(Closed)
Created 5 years, 5 months ago by Peter Kasting
Modified 5 years, 4 months ago
Reviewers: henrika_webrtc
Base URL: https://chromium.googlesource.com/external/webrtc@master
Comments: 4
Chromium Code Reviews
Issue
1228823003:
Update audio code to use size_t more correctly, webrtc/modules/audio_device/ (Closed)
