Update audio code to use size_t more correctly,

webrtc/common_audio/signal_processing/min_max_operations_mips.c

 /*
  *  Copyright (c) 2013 The WebRTC project authors. All Rights Reserved.
  *
  *  Use of this source code is governed by a BSD-style license
  *  that can be found in the LICENSE file in the root of the source
  *  tree. An additional intellectual property rights grant can be found
  *  in the file PATENTS.  All contributing project authors may
  *  be found in the AUTHORS file in the root of the source tree.
  */
 
 /*
  * This file contains the implementation of function
  * WebRtcSpl_MaxAbsValueW16()
  *
  * The description header can be found in signal_processing_library.h.
  *
  */
 
 #include "webrtc/common_audio/signal_processing/include/signal_processing_library.h"
 
 // Maximum absolute value of word16 vector.
-int16_t WebRtcSpl_MaxAbsValueW16_mips(const int16_t* vector, int length) {
+int16_t WebRtcSpl_MaxAbsValueW16_mips(const int16_t* vector, size_t length) {
   int32_t totMax = 0;
   int32_t tmp32_0, tmp32_1, tmp32_2, tmp32_3;
-  int i, loop_size;
+  size_t i, loop_size;
 
-  if (vector == NULL || length <= 0) {
+  if (vector == NULL || length == 0) {

[Andrew MacDonald, 2015/07/22 19:54:58]

Remove the checks in this file as well, if that's what we end up with in the C
version.

     return -1;
   }
 #if defined(MIPS_DSP_R1)
   const int32_t* tmpvec32 = (int32_t*)vector;
   loop_size = length >> 4;
 
   for (i = 0; i < loop_size; i++) {
     __asm__ volatile (
       "lw         %[tmp32_0],     0(%[tmpvec32])              \n\t"
       "lw         %[tmp32_1],     4(%[tmpvec32])              \n\t"
@@ skipping 177 matching lines @@
     "movn   %[totMax],  %[v16MaxMax],   %[r]        \n\t"
     : [totMax] "+r" (totMax), [r] "=&r" (r)
     : [v16MaxMax] "r" (v16MaxMax)
   );
 #endif  // #if defined(MIPS_DSP_R1)
   return (int16_t)totMax;
 }
 
 #if defined(MIPS_DSP_R1_LE)
 // Maximum absolute value of word32 vector. Version for MIPS platform.
-int32_t WebRtcSpl_MaxAbsValueW32_mips(const int32_t* vector, int length) {
+int32_t WebRtcSpl_MaxAbsValueW32_mips(const int32_t* vector, size_t length) {
   // Use uint32_t for the local variables, to accommodate the return value
   // of abs(0x80000000), which is 0x80000000.
 
   uint32_t absolute = 0, maximum = 0;
   int tmp1 = 0, max_value = 0x7fffffff;
 
-  if (vector == NULL || length <= 0) {
+  if (vector == NULL || length == 0) {
     return -1;
   }
 
   __asm__ volatile (
     ".set push                                                        \n\t"
     ".set noreorder                                                   \n\t"
 
    "1:                                                                \n\t"
     "lw         %[absolute],      0(%[vector])                        \n\t"
     "absq_s.w   %[absolute],      %[absolute]                         \n\t"
@@ skipping 10 matching lines @@
     : [tmp1] "=&r" (tmp1), [maximum] "+r" (maximum), [absolute] "+r" (absolute)
     : [vector] "r" (vector), [length] "r" (length), [max_value] "r" (max_value)
     : "memory"
   );
 
   return (int32_t)maximum;
 }
 #endif  // #if defined(MIPS_DSP_R1_LE)
 
 // Maximum value of word16 vector. Version for MIPS platform.
-int16_t WebRtcSpl_MaxValueW16_mips(const int16_t* vector, int length) {
+int16_t WebRtcSpl_MaxValueW16_mips(const int16_t* vector, size_t length) {
   int16_t maximum = WEBRTC_SPL_WORD16_MIN;
   int tmp1;
   int16_t value;
 
-  if (vector == NULL || length <= 0) {
+  if (vector == NULL || length == 0) {
     return maximum;
   }
 
   __asm__ volatile (
     ".set push                                                        \n\t"
     ".set noreorder                                                   \n\t"
 
    "1:                                                                \n\t"
     "lh         %[value],         0(%[vector])                        \n\t"
     "addiu      %[length],        %[length],          -1              \n\t"
     "slt        %[tmp1],          %[maximum],         %[value]        \n\t"
     "movn       %[maximum],       %[value],           %[tmp1]         \n\t"
     "bgtz       %[length],        1b                                  \n\t"
     " addiu     %[vector],        %[vector],          2               \n\t"
     ".set pop                                                         \n\t"
 
     : [tmp1] "=&r" (tmp1), [maximum] "+r" (maximum), [value] "=&r" (value)
     : [vector] "r" (vector), [length] "r" (length)
     : "memory"
   );
 
   return maximum;
 }
 
 // Maximum value of word32 vector. Version for MIPS platform.
-int32_t WebRtcSpl_MaxValueW32_mips(const int32_t* vector, int length) {
+int32_t WebRtcSpl_MaxValueW32_mips(const int32_t* vector, size_t length) {
   int32_t maximum = WEBRTC_SPL_WORD32_MIN;
   int tmp1, value;
 
-  if (vector == NULL || length <= 0) {
+  if (vector == NULL || length == 0) {
     return maximum;
   }
 
   __asm__ volatile (
     ".set push                                                        \n\t"
     ".set noreorder                                                   \n\t"
 
    "1:                                                                \n\t"
     "lw         %[value],         0(%[vector])                        \n\t"
     "addiu      %[length],        %[length],          -1              \n\t"
     "slt        %[tmp1],          %[maximum],         %[value]        \n\t"
     "movn       %[maximum],       %[value],           %[tmp1]         \n\t"
     "bgtz       %[length],        1b                                  \n\t"
     " addiu     %[vector],        %[vector],          4               \n\t"
 
     ".set pop                                                         \n\t"
 
     : [tmp1] "=&r" (tmp1), [maximum] "+r" (maximum), [value] "=&r" (value)
     : [vector] "r" (vector), [length] "r" (length)
     : "memory"
   );
 
   return maximum;
 }
 
 // Minimum value of word16 vector. Version for MIPS platform.
-int16_t WebRtcSpl_MinValueW16_mips(const int16_t* vector, int length) {
+int16_t WebRtcSpl_MinValueW16_mips(const int16_t* vector, size_t length) {
   int16_t minimum = WEBRTC_SPL_WORD16_MAX;
   int tmp1;
   int16_t value;
 
-  if (vector == NULL || length <= 0) {
+  if (vector == NULL || length == 0) {
     return minimum;
   }
 
   __asm__ volatile (
     ".set push                                                        \n\t"
     ".set noreorder                                                   \n\t"
 
    "1:                                                                \n\t"
     "lh         %[value],         0(%[vector])                        \n\t"
     "addiu      %[length],        %[length],          -1              \n\t"
     "slt        %[tmp1],          %[value],           %[minimum]      \n\t"
     "movn       %[minimum],       %[value],           %[tmp1]         \n\t"
     "bgtz       %[length],        1b                                  \n\t"
     " addiu     %[vector],        %[vector],          2               \n\t"
 
     ".set pop                                                         \n\t"
 
     : [tmp1] "=&r" (tmp1), [minimum] "+r" (minimum), [value] "=&r" (value)
     : [vector] "r" (vector), [length] "r" (length)
     : "memory"
   );
 
   return minimum;
 }
 
 // Minimum value of word32 vector. Version for MIPS platform.
-int32_t WebRtcSpl_MinValueW32_mips(const int32_t* vector, int length) {
+int32_t WebRtcSpl_MinValueW32_mips(const int32_t* vector, size_t length) {
   int32_t minimum = WEBRTC_SPL_WORD32_MAX;
   int tmp1, value;
 
-  if (vector == NULL || length <= 0) {
+  if (vector == NULL || length == 0) {
     return minimum;
   }
 
   __asm__ volatile (
     ".set push                                                        \n\t"
     ".set noreorder                                                   \n\t"
 
    "1:                                                                \n\t"
     "lw         %[value],         0(%[vector])                        \n\t"
     "addiu      %[length],        %[length],          -1              \n\t"
     "slt        %[tmp1],          %[value],           %[minimum]      \n\t"
     "movn       %[minimum],       %[value],           %[tmp1]         \n\t"
     "bgtz       %[length],        1b                                  \n\t"
     " addiu     %[vector],        %[vector],          4               \n\t"
 
     ".set pop                                                         \n\t"
 
     : [tmp1] "=&r" (tmp1), [minimum] "+r" (minimum), [value] "=&r" (value)
     : [vector] "r" (vector), [length] "r" (length)
     : "memory"
   );
 
   return minimum;
 }