Update audio code to use size_t more correctly,

Update audio code to use size_t more correctly,
webrtc/modules/audio_processing/vad/ portion.

This is a piece of https://codereview.webrtc.org/1230503003 , split out to a
separate change to make reviewing easier.

BUG=chromium:81439
TEST=none

[Peter Kasting, 2015-07-10 16:52:27]

pkasting@chromium.org changed reviewers:
+ andrew@webrtc.org

[Peter Kasting, 2015-07-17 00:06:50]

pkasting@chromium.org changed reviewers:
+ aluebs@webrtc.org

[Peter Kasting, 2015-07-17 00:07:18]

No good deed goes unpunished: aluebs, andrew is not responding, adding you as an
alternate OWNER

[aluebs-webrtc, 2015-07-17 01:04:42]

No punishment at all, my pleasure! In fact, thank you for doing this! It is
awesome! :)
It looks good, but I have 2 comments.

https://codereview.webrtc.org/1228803003/diff/20001/webrtc/modules/audio_proc...
File webrtc/modules/audio_processing/vad/pole_zero_filter.cc (right):

https://codereview.webrtc.org/1228803003/diff/20001/webrtc/modules/audio_proc...
webrtc/modules/audio_processing/vad/pole_zero_filter.cc:29:
static_cast<size_t>(order_numerator),
I guess that changing the interface of PoleZeroFilter::Create(...) to use size_t
as well would expand this CL hugely, right? Else it would be nice to avoid these
casts.

https://codereview.webrtc.org/1228803003/diff/20001/webrtc/modules/audio_proc...
File webrtc/modules/audio_processing/vad/vad_audio_proc.h (left):

https://codereview.webrtc.org/1228803003/diff/20001/webrtc/modules/audio_proc...
webrtc/modules/audio_processing/vad/vad_audio_proc.h:67: int ip_[kIpLength];
This is a helper array for the fft4g, which is actually an int*, so I think it
should remain as it is, unless there is a good reason for changing this as well.

[Peter Kasting, 2015-07-17 18:57:40]

https://codereview.webrtc.org/1228803003/diff/20001/webrtc/modules/audio_proc...
File webrtc/modules/audio_processing/vad/pole_zero_filter.cc (right):

https://codereview.webrtc.org/1228803003/diff/20001/webrtc/modules/audio_proc...
webrtc/modules/audio_processing/vad/pole_zero_filter.cc:29:
static_cast<size_t>(order_numerator),
On 2015/07/17 at 01:04:42, aluebs-webrtc wrote:
> I guess that changing the interface of PoleZeroFilter::Create(...) to use
size_t as well would expand this CL hugely, right? Else it would be nice to
avoid these casts.

Actually that change is easy, and I'm not sure why I didn't make it.  Done.

https://codereview.webrtc.org/1228803003/diff/20001/webrtc/modules/audio_proc...
File webrtc/modules/audio_processing/vad/vad_audio_proc.h (left):

https://codereview.webrtc.org/1228803003/diff/20001/webrtc/modules/audio_proc...
webrtc/modules/audio_processing/vad/vad_audio_proc.h:67: int ip_[kIpLength];
On 2015/07/17 at 01:04:42, aluebs-webrtc wrote:
> This is a helper array for the fft4g, which is actually an int*, so I think it
should remain as it is, unless there is a good reason for changing this as well.

This is changing in sync with that -- see
https://codereview.webrtc.org/1227203003/diff/1/webrtc/common_audio/fft4g.h .

[aluebs-webrtc, 2015-07-17 23:16:58]

lgtm

https://codereview.webrtc.org/1228803003/diff/20001/webrtc/modules/audio_proc...
File webrtc/modules/audio_processing/vad/pole_zero_filter.cc (right):

https://codereview.webrtc.org/1228803003/diff/20001/webrtc/modules/audio_proc...
webrtc/modules/audio_processing/vad/pole_zero_filter.cc:29:
static_cast<size_t>(order_numerator),
On 2015/07/17 18:57:40, Peter Kasting wrote:
> On 2015/07/17 at 01:04:42, aluebs-webrtc wrote:
> > I guess that changing the interface of PoleZeroFilter::Create(...) to use
> size_t as well would expand this CL hugely, right? Else it would be nice to
> avoid these casts.
> 
> Actually that change is easy, and I'm not sure why I didn't make it.  Done.

Awesome! :)

https://codereview.webrtc.org/1228803003/diff/20001/webrtc/modules/audio_proc...
File webrtc/modules/audio_processing/vad/vad_audio_proc.h (left):

https://codereview.webrtc.org/1228803003/diff/20001/webrtc/modules/audio_proc...
webrtc/modules/audio_processing/vad/vad_audio_proc.h:67: int ip_[kIpLength];
On 2015/07/17 18:57:40, Peter Kasting wrote:
> On 2015/07/17 at 01:04:42, aluebs-webrtc wrote:
> > This is a helper array for the fft4g, which is actually an int*, so I think
it
> should remain as it is, unless there is a good reason for changing this as
well.
> 
> This is changing in sync with that -- see
> https://codereview.webrtc.org/1227203003/diff/1/webrtc/common_audio/fft4g.h .

Oh, I see. I was not aware of that. Then it looks good.

[Andrew MacDonald, 2015-07-25 01:44:23]

On 2015/07/17 00:07:18, Peter Kasting wrote:
> No good deed goes unpunished: aluebs, andrew is not responding, adding you as
an
> alternate OWNER

FTR I was on vacation :) Should have updated my nickname.

[Andrew MacDonald, 2015-07-25 01:45:14]

lgtm