Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(248)

Side by Side Diff: webrtc/modules/audio_coding/codecs/isac/main/source/isac_unittest.cc

Issue 1228793004: Update audio code to use size_t more correctly, (Closed) Base URL: https://chromium.googlesource.com/external/webrtc@master
Patch Set: Resync Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (c) 2013 The WebRTC project authors. All Rights Reserved. 2 * Copyright (c) 2013 The WebRTC project authors. All Rights Reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 #include <string> 10 #include <string>
(...skipping 78 matching lines...) Expand 10 before | Expand all | Expand 10 after
89 encoded_bytes = WebRtcIsac_Encode(isac_codec_, speech_data_, bitstream_); 89 encoded_bytes = WebRtcIsac_Encode(isac_codec_, speech_data_, bitstream_);
90 EXPECT_EQ(0, encoded_bytes); 90 EXPECT_EQ(0, encoded_bytes);
91 encoded_bytes = WebRtcIsac_Encode(isac_codec_, speech_data_, bitstream_); 91 encoded_bytes = WebRtcIsac_Encode(isac_codec_, speech_data_, bitstream_);
92 EXPECT_EQ(0, encoded_bytes); 92 EXPECT_EQ(0, encoded_bytes);
93 encoded_bytes = WebRtcIsac_Encode(isac_codec_, speech_data_, bitstream_); 93 encoded_bytes = WebRtcIsac_Encode(isac_codec_, speech_data_, bitstream_);
94 EXPECT_EQ(0, encoded_bytes); 94 EXPECT_EQ(0, encoded_bytes);
95 encoded_bytes = WebRtcIsac_Encode(isac_codec_, speech_data_, bitstream_); 95 encoded_bytes = WebRtcIsac_Encode(isac_codec_, speech_data_, bitstream_);
96 EXPECT_EQ(0, encoded_bytes); 96 EXPECT_EQ(0, encoded_bytes);
97 encoded_bytes = WebRtcIsac_Encode(isac_codec_, speech_data_, bitstream_); 97 encoded_bytes = WebRtcIsac_Encode(isac_codec_, speech_data_, bitstream_);
98 EXPECT_EQ(0, encoded_bytes); 98 EXPECT_EQ(0, encoded_bytes);
99 encoded_bytes = WebRtcIsac_Encode(isac_codec_, speech_data_, bitstream_); 99 encoded_bytes = WebRtcIsac_Encode(isac_codec_, speech_data_, bitstream_);
minyue-webrtc 2015/07/31 14:10:14 Add EXPECT_GT(encoded_bytes, 0)
Peter Kasting 2015/08/04 02:02:53 OK, just try to avoid suggesting I make too many f
minyue-webrtc 2015/08/06 14:07:27 Ok, I think it was missing. But I also want to mak
100 100
101 // Call to update bandwidth estimator with real data. 101 // Call to update bandwidth estimator with real data.
102 EXPECT_EQ(0, WebRtcIsac_UpdateBwEstimate(isac_codec_, bitstream_, 102 EXPECT_EQ(0, WebRtcIsac_UpdateBwEstimate(isac_codec_, bitstream_,
103 encoded_bytes, 1, 12345, 56789)); 103 static_cast<size_t>(encoded_bytes),
104 1, 12345, 56789));
104 105
105 // Free memory. 106 // Free memory.
106 EXPECT_EQ(0, WebRtcIsac_Free(isac_codec_)); 107 EXPECT_EQ(0, WebRtcIsac_Free(isac_codec_));
107 } 108 }
108 109
109 } // namespace webrtc 110 } // namespace webrtc
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698