Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1320)

Unified Diff: webrtc/video/end_to_end_tests.cc

Issue 1228393008: Add resolution and fps stats to histograms. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: added render fps Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/video/end_to_end_tests.cc
diff --git a/webrtc/video/end_to_end_tests.cc b/webrtc/video/end_to_end_tests.cc
index 82fbe3ae529f7d05e993573a1dbf24a42d5252e6..139e38696e23bb0f4f194fc633f86c3b1b9a74ed 100644
--- a/webrtc/video/end_to_end_tests.cc
+++ b/webrtc/video/end_to_end_tests.cc
@@ -1634,10 +1634,32 @@ void EndToEndTest::VerifyHistogramStats(bool use_rtx, bool use_red) {
EXPECT_EQ(1, test::NumHistogramSamples(
"WebRTC.Video.ReceivedPacketsLostInPercent"));
+ EXPECT_EQ(1, test::NumHistogramSamples("WebRTC.Video.InputWidthInPixels"));
+ EXPECT_EQ(1, test::NumHistogramSamples("WebRTC.Video.InputHeightInPixels"));
+ EXPECT_EQ(1, test::NumHistogramSamples("WebRTC.Video.SentWidthInPixels"));
+ EXPECT_EQ(1, test::NumHistogramSamples("WebRTC.Video.SentHeightInPixels"));
+ EXPECT_EQ(1, test::NumHistogramSamples("WebRTC.Video.ReceivedWidthInPixels"));
+ EXPECT_EQ(1, test::NumHistogramSamples(
+ "WebRTC.Video.ReceivedHeightInPixels"));
+
+ EXPECT_EQ(static_cast<int>(encoder_config_.streams[0].width),
+ test::LastHistogramSample("WebRTC.Video.InputWidthInPixels"));
+ EXPECT_EQ(static_cast<int>(encoder_config_.streams[0].height),
+ test::LastHistogramSample("WebRTC.Video.InputHeightInPixels"));
+ EXPECT_EQ(static_cast<int>(encoder_config_.streams[0].width),
+ test::LastHistogramSample("WebRTC.Video.SentWidthInPixels"));
+ EXPECT_EQ(static_cast<int>(encoder_config_.streams[0].height),
+ test::LastHistogramSample("WebRTC.Video.SentHeightInPixels"));
+ EXPECT_EQ(static_cast<int>(encoder_config_.streams[0].width),
+ test::LastHistogramSample("WebRTC.Video.ReceivedWidthInPixels"));
+ EXPECT_EQ(static_cast<int>(encoder_config_.streams[0].height),
+ test::LastHistogramSample("WebRTC.Video.ReceivedHeightInPixels"));
+
EXPECT_EQ(1, test::NumHistogramSamples("WebRTC.Video.InputFramesPerSecond"));
EXPECT_EQ(1, test::NumHistogramSamples("WebRTC.Video.SentFramesPerSecond"));
EXPECT_EQ(1, test::NumHistogramSamples(
"WebRTC.Video.DecodedFramesPerSecond"));
+ EXPECT_EQ(1, test::NumHistogramSamples("WebRTC.Video.RenderFramesPerSecond"));
EXPECT_EQ(1, test::NumHistogramSamples(
"WebRTC.Video.BitrateSentInKbps"));

Powered by Google App Engine
This is Rietveld 408576698