Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Issue 1228193002: Remove a superfluous qualifier on an inline method. (Closed)

Created:
5 years, 5 months ago by Nico
Modified:
5 years, 5 months ago
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Remove a superfluous qualifier on an inline method. Fixes ..\..\third_party\webrtc/base/stringutils.h(295,49) : warning(clang): extra qualification on member "empty_str" [-Wmicrosoft] No behavior change, but makes the code more standards-conformant. BUG=chromium:505296 Committed: https://crrev.com/97f44e1bf6ea116fff03bc204c305fffeb08467f Cr-Commit-Position: refs/heads/master@{#9562}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M webrtc/base/stringutils.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
Nico
first to stamp wins!
5 years, 5 months ago (2015-07-09 22:26:25 UTC) #2
Sergey Ulanov
lgtm
5 years, 5 months ago (2015-07-09 22:39:24 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1228193002/1
5 years, 5 months ago (2015-07-09 22:40:35 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 5 months ago (2015-07-09 23:46:05 UTC) #6
commit-bot: I haz the power
5 years, 5 months ago (2015-07-09 23:46:07 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/97f44e1bf6ea116fff03bc204c305fffeb08467f
Cr-Commit-Position: refs/heads/master@{#9562}

Powered by Google App Engine
This is Rietveld 408576698