Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(76)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1227843006: Fix webrtc FYI waterfall issues. (Closed)

Created:
5 years, 5 months ago by honghaiz3
Modified:
5 years, 5 months ago
Reviewers:
pthatcher1
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Base URL:
https://chromium.googlesource.com/external/webrtc@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

1. Override and virtual has to be consistent. 2. provide an implementation for SetIceConnectionReceivingTimeout so that Chrome does not complain. BUG= Committed: https://crrev.com/a03cd3fdef6c823e89c76bb097abd8b83285e4da Cr-Commit-Position: refs/heads/master@{#9574}

Patch Set 1 : Fix override inconsistence. #

Patch Set 2 : Plus, have a default implementation of SetIceConnectionTimeout #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -5 lines) Patch
M talk/app/webrtc/peerconnectioninterface.h View 1 1 chunk +1 line, -1 line 0 comments Download
M webrtc/p2p/base/p2ptransportchannel.h View 2 chunks +3 lines, -4 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
honghaiz3
This fixes a webrtc-FYI issue.
5 years, 5 months ago (2015-07-13 21:54:40 UTC) #4
pthatcher1
5 years, 5 months ago (2015-07-13 22:14:59 UTC) #5
pthatcher1
lgtm
5 years, 5 months ago (2015-07-13 22:15:03 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1227843006/60001
5 years, 5 months ago (2015-07-13 22:17:50 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:60001)
5 years, 5 months ago (2015-07-14 00:08:12 UTC) #9
commit-bot: I haz the power
5 years, 5 months ago (2015-07-14 00:08:22 UTC) #10
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/a03cd3fdef6c823e89c76bb097abd8b83285e4da
Cr-Commit-Position: refs/heads/master@{#9574}

Powered by Google App Engine
This is Rietveld 408576698