webrtc/modules/audio_processing/echo_cancellation_impl.cc - Issue 1227213002: Update audio code to use size_t more correctly, webrtc/modules/audio_processing/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/modules/audio_processing/echo_cancellation_impl.cc

Issue 1227213002: Update audio code to use size_t more correctly, webrtc/modules/audio_processing/ (Closed) Base URL: https://chromium.googlesource.com/external/webrtc@master

Patch Set: Checkpoint Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« webrtc/modules/audio_processing/beamformer/nonlinear_beamformer.cc ('K') | « webrtc/modules/audio_processing/beamformer/nonlinear_beamformer.cc ('k') | webrtc/modules/audio_processing/echo_control_mobile_impl.cc » ('j') | webrtc/modules/audio_processing/include/audio_processing.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: webrtc/modules/audio_processing/echo_cancellation_impl.cc

diff --git a/webrtc/modules/audio_processing/echo_cancellation_impl.cc b/webrtc/modules/audio_processing/echo_cancellation_impl.cc

index f13ea8bde698d1e425bea4bfe0d6a64d41343eeb..86ed9234c78bb59cb98da33fbce664a0678ac5d0 100644

--- a/webrtc/modules/audio_processing/echo_cancellation_impl.cc

+++ b/webrtc/modules/audio_processing/echo_cancellation_impl.cc

@@ -91,7 +91,7 @@ int EchoCancellationImpl::ProcessRenderAudio(const AudioBuffer* audio) {

err = WebRtcAec_BufferFarend(

my_handle,

audio->split_bands_const_f(j)[kBand0To8kHz],

- static_cast<int16_t>(audio->num_frames_per_band()));

+ audio->num_frames_per_band());

if (err != apm_->kNoError) {

return GetHandleError(my_handle); // TODO(ajm): warning possible?

@@ -133,7 +133,7 @@ int EchoCancellationImpl::ProcessCaptureAudio(AudioBuffer* audio) {

audio->split_bands_const_f(i),

audio->num_bands(),

audio->split_bands_f(i),

- static_cast<int16_t>(audio->num_frames_per_band()),

+ audio->num_frames_per_band(),

apm_->stream_delay_ms(),

stream_drift_samples_);