webrtc/modules/audio_coding/codecs/isac/fix/source/decode_bwe.c - Issue 1227163003: Update audio code to use size_t more correctly,

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/modules/audio_coding/codecs/isac/fix/source/decode_bwe.c

Issue 1227163003: Update audio code to use size_t more correctly, (Closed) Base URL: https://chromium.googlesource.com/external/webrtc@master

Patch Set: Review comments Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: webrtc/modules/audio_coding/codecs/isac/fix/source/decode_bwe.c

diff --git a/webrtc/modules/audio_coding/codecs/isac/fix/source/decode_bwe.c b/webrtc/modules/audio_coding/codecs/isac/fix/source/decode_bwe.c

index b1f5d10a6551d49307f56d4d80e5483372039329..316f59a5e2fe49b9d5b768095bb16edadefe6591 100644

--- a/webrtc/modules/audio_coding/codecs/isac/fix/source/decode_bwe.c

+++ b/webrtc/modules/audio_coding/codecs/isac/fix/source/decode_bwe.c

@@ -26,13 +26,13 @@

int WebRtcIsacfix_EstimateBandwidth(BwEstimatorstr *bwest_str,

Bitstr_dec *streamdata,

- int32_t packet_size,

+ size_t packet_size,

uint16_t rtp_seq_number,

uint32_t send_ts,

uint32_t arr_ts)

{

int16_t index;

- int16_t frame_samples;

+ size_t frame_samples;

int err;

/* decode framelength */

@@ -53,10 +53,10 @@ int WebRtcIsacfix_EstimateBandwidth(BwEstimatorstr *bwest_str,

err = WebRtcIsacfix_UpdateUplinkBwImpl(

bwest_str,

rtp_seq_number,

- frame_samples * 1000 / FS,

+ (int16_t)(frame_samples * 1000 / FS),

send_ts,

arr_ts,

- (int16_t) packet_size, /* in bytes */

+ packet_size, /* in bytes */

index);

/* error check */