webrtc/modules/audio_coding/codecs/isac/fix/source/bandwidth_estimator.c - Issue 1227163003: Update audio code to use size_t more correctly,

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/modules/audio_coding/codecs/isac/fix/source/bandwidth_estimator.c

Issue 1227163003: Update audio code to use size_t more correctly, (Closed) Base URL: https://chromium.googlesource.com/external/webrtc@master

Patch Set: Review comments Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « webrtc/modules/audio_coding/codecs/isac/fix/source/bandwidth_estimator.h ('k') | webrtc/modules/audio_coding/codecs/isac/fix/source/codec.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: webrtc/modules/audio_coding/codecs/isac/fix/source/bandwidth_estimator.c

diff --git a/webrtc/modules/audio_coding/codecs/isac/fix/source/bandwidth_estimator.c b/webrtc/modules/audio_coding/codecs/isac/fix/source/bandwidth_estimator.c

index d876a3cb837322a5414d5e91a409d477856f3ab9..b074962eae81350346e4ed28f0ae08cdb24534a4 100644

--- a/webrtc/modules/audio_coding/codecs/isac/fix/source/bandwidth_estimator.c

+++ b/webrtc/modules/audio_coding/codecs/isac/fix/source/bandwidth_estimator.c

@@ -148,7 +148,7 @@ int32_t WebRtcIsacfix_UpdateUplinkBwImpl(BwEstimatorstr *bweStr,

const int16_t frameSize,

const uint32_t sendTime,

const uint32_t arrivalTime,

- const int16_t pksize,

+ const size_t pksize,

const uint16_t Index)

{

uint16_t weight = 0;

@@ -379,7 +379,7 @@ int32_t WebRtcIsacfix_UpdateUplinkBwImpl(BwEstimatorstr *bweStr,

/* compute inverse receiving rate for last packet, in Q19 */

numBytesInv = (uint16_t) WebRtcSpl_DivW32W16(

- 524288 + ((pksize + HEADER_SIZE) >> 1),

+ (int32_t)(524288 + ((pksize + HEADER_SIZE) >> 1)),

(int16_t)(pksize + HEADER_SIZE));

/* 8389 is ~ 1/128000 in Q30 */