Issue 1226153003: Improvements to rtc::Bind

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1226153003: Improvements to rtc::Bind (Closed)

Created:
5 years, 5 months ago by Jelena

Modified:
5 years, 5 months ago

Reviewers:
the sun, pthatcher1

CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com

Base URL:
https://chromium.googlesource.com/external/webrtc.git@master

Target Ref:
refs/pending/heads/master

Project:
webrtc

Visibility:
Public.

More Reviews

Description

Improvements to rtc::Bind BUG=webrtc:4690 Support for rtc::scoped_ptr as return type. Support for up to 6 input parameters. R=pthatcher@webrtc.org, solenberg@webrtc.org Committed: https://chromium.googlesource.com/external/webrtc/+/5d6e58e76e7750a86eed2da8f0c2b62b58d8356b

Patch Set 1 #

Created: 5 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+151 lines, -1 line)			Patch
	M	webrtc/base/bind.h	View		1 chunk	+136 lines, -0 lines	0 comments	Download
	M	webrtc/base/messagehandler.h	View		3 chunks	+15 lines, -1 line	0 comments	Download

Messages

Total messages: 6 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Jelena

Committed patchset #1 (id:1) manually as 5d6e58e76e7750a86eed2da8f0c2b62b58d8356b (presubmit successful).

5 years, 5 months ago (2015-07-13 09:16:54 UTC) #5

magjed_webrtc

5 years, 5 months ago (2015-07-21 15:15:50 UTC) #6

Message was sent while issue was closed.

On 2015/07/13 09:16:54, Jelena wrote:
> Committed patchset #1 (id:1) manually as
> 5d6e58e76e7750a86eed2da8f0c2b62b58d8356b (presubmit successful).

Did you miss to commit webrtc/base/bind.h.pump or did you modify bind.h by hand?
There is a "$var n = 5" in the pump file that you can simply increase to 6. To
generate bind.h from bind.h.pump, execute:
/home/build/google3/third_party/gtest/scripts/pump.py bind.h.pump.

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages