Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Unified Diff: webrtc/video_engine/vie_channel.h

Issue 1226143013: Merge methods for configuring NACK/FEC/hybrid. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Remove distinction between send and receive NACK. Allow disabling receive-side. Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/video_engine/vie_channel.h
diff --git a/webrtc/video_engine/vie_channel.h b/webrtc/video_engine/vie_channel.h
index 426cc3a700c8b4176687adb2a2f06fd66d38df64..f12649b3f8a19aadc939deb076d27780f9166077 100644
--- a/webrtc/video_engine/vie_channel.h
+++ b/webrtc/video_engine/vie_channel.h
@@ -142,19 +142,11 @@ class ViEChannel : public VCMFrameTypeCallback,
// Only affects calls to SetReceiveCodec done after this call.
int32_t WaitForKeyFrame(bool wait);
- // If enabled, a key frame request will be sent as soon as there are lost
- // packets. If |only_key_frames| are set, requests are only sent for loss in
- // key frames.
- int32_t SetSignalPacketLossStatus(bool enable, bool only_key_frames);
-
void SetRTCPMode(const RTCPMethod rtcp_mode);
- int32_t SetNACKStatus(const bool enable);
- int32_t SetFECStatus(const bool enable,
- const unsigned char payload_typeRED,
- const unsigned char payload_typeFEC);
- int32_t SetHybridNACKFECStatus(const bool enable,
- const unsigned char payload_typeRED,
- const unsigned char payload_typeFEC);
+ void SetProtectionMode(bool enable_nack,
+ bool enable_fec,
+ int payload_type_red,
+ int payload_type_fec);
bool IsSendingFecEnabled();
int SetSenderBufferingMode(int target_delay_ms);
int SetReceiverBufferingMode(int target_delay_ms);
@@ -365,10 +357,7 @@ class ViEChannel : public VCMFrameTypeCallback,
void StartDecodeThread();
void StopDecodeThread();
- int32_t ProcessNACKRequest(const bool enable);
- int32_t ProcessFECRequest(const bool enable,
- const unsigned char payload_typeRED,
- const unsigned char payload_typeFEC);
+ void ProcessNACKRequest(const bool enable);
// Compute NACK list parameters for the buffering mode.
int GetRequiredNackListSize(int target_delay_ms);
void SetRtxSendStatus(bool enable);
@@ -494,7 +483,7 @@ class ViEChannel : public VCMFrameTypeCallback,
bool do_key_frame_callbackRequest_;
RtcpIntraFrameObserver* intra_frame_observer_;
RtcpRttStats* rtt_stats_;
- PacedSender* paced_sender_;
+ PacedSender* const paced_sender_;
PacketRouter* packet_router_;
rtc::scoped_ptr<RtcpBandwidthObserver> bandwidth_observer_;

Powered by Google App Engine
This is Rietveld 408576698