webrtc/modules/rtp_rtcp/source/rtp_sender.h - Issue 1226143013: Merge methods for configuring NACK/FEC/hybrid.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/modules/rtp_rtcp/source/rtp_sender.h

Issue 1226143013: Merge methods for configuring NACK/FEC/hybrid. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master

Patch Set: Remove distinction between send and receive NACK. Allow disabling receive-side. Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: webrtc/modules/rtp_rtcp/source/rtp_sender.h

diff --git a/webrtc/modules/rtp_rtcp/source/rtp_sender.h b/webrtc/modules/rtp_rtcp/source/rtp_sender.h

index 61a1fb5ec7926d3d2309b7d3cbb0b6260f56964b..a4703989d6e4a33323a68325b13efe392839499d 100644

--- a/webrtc/modules/rtp_rtcp/source/rtp_sender.h

+++ b/webrtc/modules/rtp_rtcp/source/rtp_sender.h

@@ -263,12 +263,13 @@ class RTPSender : public RTPSenderInterface {

int32_t SendRTPIntraRequest();

// FEC.

- int32_t SetGenericFECStatus(bool enable,

- uint8_t payload_type_red,

- uint8_t payload_type_fec);

+ void SetGenericFECStatus(bool enable,

+ uint8_t payload_type_red,

+ uint8_t payload_type_fec);

- int32_t GenericFECStatus(bool *enable, uint8_t *payload_type_red,

- uint8_t *payload_type_fec) const;

+ void GenericFECStatus(bool* enable,

+ uint8_t* payload_type_red,

+ uint8_t* payload_type_fec) const;

int32_t SetFecParameters(const FecProtectionParams *delta_params,

const FecProtectionParams *key_params);