Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(189)

Side by Side Diff: webrtc/modules/rtp_rtcp/source/rtp_sender.cc

Issue 1226143013: Merge methods for configuring NACK/FEC/hybrid. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Remove distinction between send and receive NACK. Allow disabling receive-side. Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (c) 2012 The WebRTC project authors. All Rights Reserved. 2 * Copyright (c) 2012 The WebRTC project authors. All Rights Reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 10
(...skipping 1720 matching lines...) Expand 10 before | Expand all | Expand 10 after
1731 return video_->MaxConfiguredBitrateVideo(); 1731 return video_->MaxConfiguredBitrateVideo();
1732 } 1732 }
1733 1733
1734 int32_t RTPSender::SendRTPIntraRequest() { 1734 int32_t RTPSender::SendRTPIntraRequest() {
1735 if (audio_configured_) { 1735 if (audio_configured_) {
1736 return -1; 1736 return -1;
1737 } 1737 }
1738 return video_->SendRTPIntraRequest(); 1738 return video_->SendRTPIntraRequest();
1739 } 1739 }
1740 1740
1741 int32_t RTPSender::SetGenericFECStatus(bool enable, 1741 void RTPSender::SetGenericFECStatus(bool enable,
1742 uint8_t payload_type_red, 1742 uint8_t payload_type_red,
1743 uint8_t payload_type_fec) { 1743 uint8_t payload_type_fec) {
1744 if (audio_configured_) { 1744 DCHECK(!audio_configured_);
1745 return -1;
1746 }
1747 video_->SetGenericFECStatus(enable, payload_type_red, payload_type_fec); 1745 video_->SetGenericFECStatus(enable, payload_type_red, payload_type_fec);
1748 return 0;
1749 } 1746 }
1750 1747
1751 int32_t RTPSender::GenericFECStatus(bool* enable, 1748 void RTPSender::GenericFECStatus(bool* enable,
1752 uint8_t* payload_type_red, 1749 uint8_t* payload_type_red,
1753 uint8_t* payload_type_fec) const { 1750 uint8_t* payload_type_fec) const {
1754 if (audio_configured_) { 1751 DCHECK(!audio_configured_);
1755 return -1;
1756 }
1757 video_->GenericFECStatus(*enable, *payload_type_red, *payload_type_fec); 1752 video_->GenericFECStatus(*enable, *payload_type_red, *payload_type_fec);
1758 return 0;
1759 } 1753 }
1760 1754
1761 int32_t RTPSender::SetFecParameters( 1755 int32_t RTPSender::SetFecParameters(
1762 const FecProtectionParams *delta_params, 1756 const FecProtectionParams *delta_params,
1763 const FecProtectionParams *key_params) { 1757 const FecProtectionParams *key_params) {
1764 if (audio_configured_) { 1758 if (audio_configured_) {
1765 return -1; 1759 return -1;
1766 } 1760 }
1767 video_->SetFecParameters(delta_params, key_params); 1761 video_->SetFecParameters(delta_params, key_params);
1768 return 0; 1762 return 0;
(...skipping 88 matching lines...) Expand 10 before | Expand all | Expand 10 after
1857 CriticalSectionScoped lock(send_critsect_.get()); 1851 CriticalSectionScoped lock(send_critsect_.get());
1858 1852
1859 RtpState state; 1853 RtpState state;
1860 state.sequence_number = sequence_number_rtx_; 1854 state.sequence_number = sequence_number_rtx_;
1861 state.start_timestamp = start_timestamp_; 1855 state.start_timestamp = start_timestamp_;
1862 1856
1863 return state; 1857 return state;
1864 } 1858 }
1865 1859
1866 } // namespace webrtc 1860 } // namespace webrtc
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698