Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Side by Side Diff: webrtc/modules/rtp_rtcp/source/rtp_rtcp_impl.cc

Issue 1226143013: Merge methods for configuring NACK/FEC/hybrid. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Remove distinction between send and receive NACK. Allow disabling receive-side. Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (c) 2012 The WebRTC project authors. All Rights Reserved. 2 * Copyright (c) 2012 The WebRTC project authors. All Rights Reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 10
(...skipping 791 matching lines...) Expand 10 before | Expand all | Expand 10 after
802 } 802 }
803 return -1; 803 return -1;
804 } 804 }
805 805
806 int32_t ModuleRtpRtcpImpl::SendRTCPSliceLossIndication( 806 int32_t ModuleRtpRtcpImpl::SendRTCPSliceLossIndication(
807 const uint8_t picture_id) { 807 const uint8_t picture_id) {
808 return rtcp_sender_.SendRTCP( 808 return rtcp_sender_.SendRTCP(
809 GetFeedbackState(), kRtcpSli, 0, 0, false, picture_id); 809 GetFeedbackState(), kRtcpSli, 0, 0, false, picture_id);
810 } 810 }
811 811
812 int32_t ModuleRtpRtcpImpl::SetGenericFECStatus( 812 void ModuleRtpRtcpImpl::SetGenericFECStatus(
813 const bool enable, 813 const bool enable,
814 const uint8_t payload_type_red, 814 const uint8_t payload_type_red,
815 const uint8_t payload_type_fec) { 815 const uint8_t payload_type_fec) {
816 return rtp_sender_.SetGenericFECStatus(enable, 816 rtp_sender_.SetGenericFECStatus(enable, payload_type_red, payload_type_fec);
817 payload_type_red,
818 payload_type_fec);
819 } 817 }
820 818
821 int32_t ModuleRtpRtcpImpl::GenericFECStatus( 819 void ModuleRtpRtcpImpl::GenericFECStatus(bool& enable,
822 bool& enable, 820 uint8_t& payload_type_red,
823 uint8_t& payload_type_red, 821 uint8_t& payload_type_fec) {
824 uint8_t& payload_type_fec) { 822 rtp_sender_.GenericFECStatus(&enable, &payload_type_red,
825 return rtp_sender_.GenericFECStatus(&enable, &payload_type_red,
826 &payload_type_fec); 823 &payload_type_fec);
827 } 824 }
828 825
829 int32_t ModuleRtpRtcpImpl::SetFecParameters( 826 int32_t ModuleRtpRtcpImpl::SetFecParameters(
830 const FecProtectionParams* delta_params, 827 const FecProtectionParams* delta_params,
831 const FecProtectionParams* key_params) { 828 const FecProtectionParams* key_params) {
832 return rtp_sender_.SetFecParameters(delta_params, key_params); 829 return rtp_sender_.SetFecParameters(delta_params, key_params);
833 } 830 }
834 831
835 void ModuleRtpRtcpImpl::SetRemoteSSRC(const uint32_t ssrc) { 832 void ModuleRtpRtcpImpl::SetRemoteSSRC(const uint32_t ssrc) {
(...skipping 133 matching lines...) Expand 10 before | Expand all | Expand 10 after
969 void ModuleRtpRtcpImpl::RegisterSendChannelRtpStatisticsCallback( 966 void ModuleRtpRtcpImpl::RegisterSendChannelRtpStatisticsCallback(
970 StreamDataCountersCallback* callback) { 967 StreamDataCountersCallback* callback) {
971 rtp_sender_.RegisterRtpStatisticsCallback(callback); 968 rtp_sender_.RegisterRtpStatisticsCallback(callback);
972 } 969 }
973 970
974 StreamDataCountersCallback* 971 StreamDataCountersCallback*
975 ModuleRtpRtcpImpl::GetSendChannelRtpStatisticsCallback() const { 972 ModuleRtpRtcpImpl::GetSendChannelRtpStatisticsCallback() const {
976 return rtp_sender_.GetRtpStatisticsCallback(); 973 return rtp_sender_.GetRtpStatisticsCallback();
977 } 974 }
978 } // namespace webrtc 975 } // namespace webrtc
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698