Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2086)

Unified Diff: webrtc/video/end_to_end_tests.cc

Issue 1226123005: Define Stream base classes (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Code review follow-up 3 Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « webrtc/video/audio_receive_stream.cc ('k') | webrtc/video/video_receive_stream.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/video/end_to_end_tests.cc
diff --git a/webrtc/video/end_to_end_tests.cc b/webrtc/video/end_to_end_tests.cc
index 82fbe3ae529f7d05e993573a1dbf24a42d5252e6..ab4dfaf65aafc2ee7bed03f541edc6bb16381509 100644
--- a/webrtc/video/end_to_end_tests.cc
+++ b/webrtc/video/end_to_end_tests.cc
@@ -2509,7 +2509,7 @@ TEST_F(EndToEndTest, RespectsNetworkState) {
FakeEncoder(Clock::GetRealTimeClock()),
encoded_frames_(EventWrapper::Create()),
packet_event_(EventWrapper::Create()),
- sender_state_(Call::kNetworkUp),
+ sender_state_(kNetworkUp),
sender_rtp_(0),
sender_rtcp_(0),
receiver_rtcp_(0),
@@ -2559,17 +2559,17 @@ TEST_F(EndToEndTest, RespectsNetworkState) {
WaitForPacketsOrSilence(false, false);
// Sender-side network down.
- sender_call_->SignalNetworkState(Call::kNetworkDown);
+ sender_call_->SignalNetworkState(kNetworkDown);
{
rtc::CritScope lock(&test_crit_);
// After network goes down we shouldn't be encoding more frames.
- sender_state_ = Call::kNetworkDown;
+ sender_state_ = kNetworkDown;
}
// Wait for receiver-packets and no sender packets.
WaitForPacketsOrSilence(true, false);
// Receiver-side network down.
- receiver_call_->SignalNetworkState(Call::kNetworkDown);
+ receiver_call_->SignalNetworkState(kNetworkDown);
WaitForPacketsOrSilence(true, true);
// Network back up again for both.
@@ -2577,10 +2577,10 @@ TEST_F(EndToEndTest, RespectsNetworkState) {
rtc::CritScope lock(&test_crit_);
// It's OK to encode frames again, as we're about to bring up the
// network.
- sender_state_ = Call::kNetworkUp;
+ sender_state_ = kNetworkUp;
}
- sender_call_->SignalNetworkState(Call::kNetworkUp);
- receiver_call_->SignalNetworkState(Call::kNetworkUp);
+ sender_call_->SignalNetworkState(kNetworkUp);
+ receiver_call_->SignalNetworkState(kNetworkUp);
WaitForPacketsOrSilence(false, false);
}
@@ -2589,7 +2589,7 @@ TEST_F(EndToEndTest, RespectsNetworkState) {
const std::vector<VideoFrameType>* frame_types) override {
{
rtc::CritScope lock(&test_crit_);
- if (sender_state_ == Call::kNetworkDown) {
+ if (sender_state_ == kNetworkDown) {
++down_frames_;
EXPECT_LE(down_frames_, 1)
<< "Encoding more than one frame while network is down.";
@@ -2655,7 +2655,7 @@ TEST_F(EndToEndTest, RespectsNetworkState) {
const rtc::scoped_ptr<EventWrapper> packet_event_;
Call* sender_call_;
Call* receiver_call_;
- Call::NetworkState sender_state_ GUARDED_BY(test_crit_);
+ NetworkState sender_state_ GUARDED_BY(test_crit_);
int sender_rtp_ GUARDED_BY(test_crit_);
int sender_rtcp_ GUARDED_BY(test_crit_);
int receiver_rtcp_ GUARDED_BY(test_crit_);
@@ -2720,7 +2720,7 @@ TEST_F(EndToEndTest, NewSendStreamsRespectNetworkDown) {
UnusedTransport transport;
CreateSenderCall(Call::Config(&transport));
- sender_call_->SignalNetworkState(Call::kNetworkDown);
+ sender_call_->SignalNetworkState(kNetworkDown);
CreateSendConfig(1);
UnusedEncoder unused_encoder;
@@ -2742,7 +2742,7 @@ TEST_F(EndToEndTest, NewReceiveStreamsRespectNetworkDown) {
CreateReceiverCall(Call::Config(&transport));
sender_transport.SetReceiver(receiver_call_->Receiver());
- receiver_call_->SignalNetworkState(Call::kNetworkDown);
+ receiver_call_->SignalNetworkState(kNetworkDown);
CreateSendConfig(1);
CreateMatchingReceiveConfigs();
« no previous file with comments | « webrtc/video/audio_receive_stream.cc ('k') | webrtc/video/video_receive_stream.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698