Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(931)

Unified Diff: talk/media/webrtc/webrtcvideoengine2_unittest.cc

Issue 1226093010: Nuke buffered latency mode. It's not actually working, and it's not used. It's just dead code com… (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « talk/media/webrtc/webrtcvideoengine2.cc ('k') | talk/session/media/channel.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: talk/media/webrtc/webrtcvideoengine2_unittest.cc
diff --git a/talk/media/webrtc/webrtcvideoengine2_unittest.cc b/talk/media/webrtc/webrtcvideoengine2_unittest.cc
index 71eebba0b0afd5e6ac95155e38100cb176a497dd..51fc765ccd4ab2624c4b105c98f2671caba7876e 100644
--- a/talk/media/webrtc/webrtcvideoengine2_unittest.cc
+++ b/talk/media/webrtc/webrtcvideoengine2_unittest.cc
@@ -2182,6 +2182,8 @@ TEST_F(WebRtcVideoChannel2Test, TestSetDscpOptions) {
new cricket::FakeNetworkInterface);
channel_->SetInterface(network_interface.get());
cricket::VideoOptions options;
+ EXPECT_TRUE(channel_->SetOptions(options));
+ EXPECT_EQ(rtc::DSCP_DEFAULT, network_interface->dscp());
pbos-webrtc 2015/07/14 03:58:33 Keep this line, we should be doing DSCP_DEFAULT by
pthatcher1 2015/07/16 07:41:35 Arguably, DSCP_NO_CHANGE is correct. It means the
options.dscp.Set(true);
EXPECT_TRUE(channel_->SetOptions(options));
EXPECT_EQ(rtc::DSCP_AF41, network_interface->dscp());
« no previous file with comments | « talk/media/webrtc/webrtcvideoengine2.cc ('k') | talk/session/media/channel.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698