Nuke buffered latency mode. It's not actually working, and it's not used. It's just dead code com…

talk/media/webrtc/webrtcvideoengine2_unittest.cc

 /*
  * libjingle
  * Copyright 2004 Google Inc.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are met:
  *
  *  1. Redistributions of source code must retain the above copyright notice,
  *     this list of conditions and the following disclaimer.
  *  2. Redistributions in binary form must reproduce the above copyright notice,
@@ skipping 2164 matching lines @@
   EXPECT_TRUE(new_stream->IsSending())
       << "Send stream created after SetSend(true) not sending initially.";
 }
 
 // This test verifies DSCP settings are properly applied on video media channel.
 TEST_F(WebRtcVideoChannel2Test, TestSetDscpOptions) {
   rtc::scoped_ptr<cricket::FakeNetworkInterface> network_interface(
       new cricket::FakeNetworkInterface);
   channel_->SetInterface(network_interface.get());
   cricket::VideoOptions options;
+  EXPECT_TRUE(channel_->SetOptions(options));
+  EXPECT_EQ(rtc::DSCP_DEFAULT, network_interface->dscp());

[pbos-webrtc, 2015/07/14 03:58:33]

Keep this line, we should be doing DSCP_DEFAULT by default, right?

If this doesn't work straight off the bat, I think ::SetInterface should set
DSCP_DEFAULT (or another value) based on current options.

[pthatcher1, 2015/07/16 07:41:35]

Arguably, DSCP_NO_CHANGE is correct.  It means the value for DSCP wasn't changed
on the socket.  And if DSCP_DEFAULT really is the default, then the behavior is
the change.  So, I've change the test to DSCP_NO_CHANGE, which matches what the
FakeNetworkInterface is when nothing is changed.

   options.dscp.Set(true);
   EXPECT_TRUE(channel_->SetOptions(options));
   EXPECT_EQ(rtc::DSCP_AF41, network_interface->dscp());
   // Verify previous value is not modified if dscp option is not set.
   cricket::VideoOptions options1;
   EXPECT_TRUE(channel_->SetOptions(options1));
   EXPECT_EQ(rtc::DSCP_AF41, network_interface->dscp());
   options.dscp.Set(false);
   EXPECT_TRUE(channel_->SetOptions(options));
   EXPECT_EQ(rtc::DSCP_DEFAULT, network_interface->dscp());
@@ skipping 887 matching lines @@
 // Ensures that the correct settings are applied to the codec when two temporal
 // layer screencasting is enabled, and that the correct simulcast settings are
 // reapplied when disabling screencasting.
 TEST_F(WebRtcVideoChannel2SimulcastTest,
        DISABLED_TwoTemporalLayerScreencastSettings) {
   // TODO(pbos): Implement.
   FAIL() << "Not implemented.";
 }
 
 }  // namespace cricket