Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Unified Diff: webrtc/modules/audio_coding/main/test/initial_delay_unittest.cc

Issue 1225133003: Update audio code to use size_t more correctly, (Closed) Base URL: https://chromium.googlesource.com/external/webrtc@master
Patch Set: Review comment Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/modules/audio_coding/main/test/initial_delay_unittest.cc
diff --git a/webrtc/modules/audio_coding/main/test/initial_delay_unittest.cc b/webrtc/modules/audio_coding/main/test/initial_delay_unittest.cc
index ffbbc8c5d13857fc6ed365f2608d21e8cc9ea187..0bac4013f530a19826c9629636fa0b6b3f897045 100644
--- a/webrtc/modules/audio_coding/main/test/initial_delay_unittest.cc
+++ b/webrtc/modules/audio_coding/main/test/initial_delay_unittest.cc
@@ -32,9 +32,9 @@ namespace webrtc {
namespace {
double FrameRms(AudioFrame& frame) {
- int samples = frame.num_channels_ * frame.samples_per_channel_;
+ size_t samples = frame.num_channels_ * frame.samples_per_channel_;
double rms = 0;
- for (int n = 0; n < samples; ++n)
+ for (size_t n = 0; n < samples; ++n)
rms += frame.data_[n] * frame.data_[n];
rms /= samples;
rms = sqrt(rms);
@@ -132,9 +132,9 @@ class InitialPlayoutDelayTest : public ::testing::Test {
in_audio_frame.sample_rate_hz_ = codec.plfreq;
in_audio_frame.num_channels_ = codec.channels;
in_audio_frame.samples_per_channel_ = codec.plfreq / 100; // 10 ms.
- int samples = in_audio_frame.num_channels_ *
+ size_t samples = in_audio_frame.num_channels_ *
in_audio_frame.samples_per_channel_;
- for (int n = 0; n < samples; ++n) {
+ for (size_t n = 0; n < samples; ++n) {
in_audio_frame.data_[n] = kAmp;
}
« no previous file with comments | « webrtc/modules/audio_coding/main/test/SpatialAudio.cc ('k') | webrtc/modules/audio_coding/main/test/opus_test.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698