webrtc/modules/audio_coding/main/acm2/audio_coding_module_unittest.cc - Issue 1225133003: Update audio code to use size_t more correctly,

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/modules/audio_coding/main/acm2/audio_coding_module_unittest.cc

Issue 1225133003: Update audio code to use size_t more correctly, (Closed) Base URL: https://chromium.googlesource.com/external/webrtc@master

Patch Set: Review comment Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « webrtc/modules/audio_coding/main/acm2/audio_coding_module_impl.cc ('k') | webrtc/modules/audio_coding/main/acm2/audio_coding_module_unittest_oldapi.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: webrtc/modules/audio_coding/main/acm2/audio_coding_module_unittest.cc

diff --git a/webrtc/modules/audio_coding/main/acm2/audio_coding_module_unittest.cc b/webrtc/modules/audio_coding/main/acm2/audio_coding_module_unittest.cc

index eea51a3489e285df9592de02cc21d500f4d99a65..418ddd111f104eb67f71c6216fdeaf4764f9a20e 100644

--- a/webrtc/modules/audio_coding/main/acm2/audio_coding_module_unittest.cc

+++ b/webrtc/modules/audio_coding/main/acm2/audio_coding_module_unittest.cc

@@ -272,7 +272,8 @@ TEST_F(AudioCodingModuleTest, VerifyOutputFrame) {

EXPECT_TRUE(acm_->Get10MsAudio(&audio_frame));

EXPECT_EQ(0u, audio_frame.timestamp_);

EXPECT_GT(audio_frame.num_channels_, 0);

- EXPECT_EQ(kSampleRateHz / 100, audio_frame.samples_per_channel_);

+ EXPECT_EQ(static_cast<size_t>(kSampleRateHz / 100),

+ audio_frame.samples_per_channel_);

EXPECT_EQ(kSampleRateHz, audio_frame.sample_rate_hz_);

}