webrtc/modules/audio_coding/main/acm2/acm_receive_test_oldapi.cc - Issue 1225133003: Update audio code to use size_t more correctly,

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/modules/audio_coding/main/acm2/acm_receive_test_oldapi.cc

Issue 1225133003: Update audio code to use size_t more correctly, (Closed) Base URL: https://chromium.googlesource.com/external/webrtc@master

Patch Set: Review comment Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: webrtc/modules/audio_coding/main/acm2/acm_receive_test_oldapi.cc

diff --git a/webrtc/modules/audio_coding/main/acm2/acm_receive_test_oldapi.cc b/webrtc/modules/audio_coding/main/acm2/acm_receive_test_oldapi.cc

index 96a1fc5fdcbe35b5ec08f2d5698d1cc02311f7fa..024503e29043557da969c01e1e56587d79cb1a3b 100644

--- a/webrtc/modules/audio_coding/main/acm2/acm_receive_test_oldapi.cc

+++ b/webrtc/modules/audio_coding/main/acm2/acm_receive_test_oldapi.cc

@@ -151,7 +151,8 @@ void AcmReceiveTestOldApi::Run() {

AudioFrame output_frame;

EXPECT_EQ(0, acm_->PlayoutData10Ms(output_freq_hz_, &output_frame));

EXPECT_EQ(output_freq_hz_, output_frame.sample_rate_hz_);

- const int samples_per_block = output_freq_hz_ * 10 / 1000;

+ const size_t samples_per_block =

+ static_cast<size_t>(output_freq_hz_ * 10 / 1000);

EXPECT_EQ(samples_per_block, output_frame.samples_per_channel_);

if (exptected_output_channels_ != kArbitraryChannels) {

if (output_frame.speech_type_ == webrtc::AudioFrame::kPLC) {