Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(477)

Issue 1224693013: Use Resampler default constructor in VAD (Closed)

Created:
5 years, 5 months ago by aluebs-webrtc
Modified:
5 years, 5 months ago
CC:
aluebs-webrtc, Andrew MacDonald, bjornv1, hlundin-webrtc, kwiberg-webrtc, tterriberry_mozilla.com, webrtc-reviews_webrtc.org
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Use Resampler default constructor in VAD Committed: https://crrev.com/cbd44e6d734037cc98b7c51d7c787fa154346b54 Cr-Commit-Position: refs/heads/master@{#9551}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -2 lines) Patch
M webrtc/modules/audio_processing/vad/voice_activity_detector.cc View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
aluebs-webrtc
5 years, 5 months ago (2015-07-08 00:08:46 UTC) #2
Peter Kasting
LGTM if it passes tests
5 years, 5 months ago (2015-07-08 00:09:45 UTC) #3
Andrew MacDonald
lgtm
5 years, 5 months ago (2015-07-08 01:17:42 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1224693013/1
5 years, 5 months ago (2015-07-08 01:21:37 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 5 months ago (2015-07-08 03:21:55 UTC) #7
commit-bot: I haz the power
5 years, 5 months ago (2015-07-08 03:22:08 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/cbd44e6d734037cc98b7c51d7c787fa154346b54
Cr-Commit-Position: refs/heads/master@{#9551}

Powered by Google App Engine
This is Rietveld 408576698