webrtc/voice_engine/test/auto_test/standard/external_media_test.cc - Issue 1224163002: Update audio code to use size_t more correctly, webrtc/voice_engine/ portion.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/voice_engine/test/auto_test/standard/external_media_test.cc

Issue 1224163002: Update audio code to use size_t more correctly, webrtc/voice_engine/ portion. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc@master

Patch Set: Checkpoint Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« webrtc/voice_engine/mock/fake_voe_external_media.h ('K') | « webrtc/voice_engine/test/auto_test/fakes/fake_media_process.h ('k') | webrtc/voice_engine/test/auto_test/standard/neteq_stats_test.cc » ('j') | webrtc/voice_engine/utility.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: webrtc/voice_engine/test/auto_test/standard/external_media_test.cc

diff --git a/webrtc/voice_engine/test/auto_test/standard/external_media_test.cc b/webrtc/voice_engine/test/auto_test/standard/external_media_test.cc

index f586b0e42d91a625b95f723bad8394b02ddbb8a3..b4daba5afddb8b5f3100f9443e19e2fcf8c8ab51 100644

--- a/webrtc/voice_engine/test/auto_test/standard/external_media_test.cc

+++ b/webrtc/voice_engine/test/auto_test/standard/external_media_test.cc

@@ -83,7 +83,7 @@ TEST_F(ExternalMediaTest,

ResumePlaying();

EXPECT_EQ(0, voe_xmedia_->GetAudioFrame(channel_, 0, &frame));

EXPECT_GT(frame.sample_rate_hz_, 0);

- EXPECT_GT(frame.samples_per_channel_, 0);

+ EXPECT_GT(frame.samples_per_channel_, 0U);

PausePlaying();

EXPECT_EQ(0, voe_xmedia_->SetExternalMixing(channel_, false));

ResumePlaying();

@@ -101,7 +101,7 @@ TEST_F(ExternalMediaTest,

EXPECT_EQ(0, voe_xmedia_->GetAudioFrame(channel_, f, &frame))

<< "Resampling succeeds for freq=" << f;

EXPECT_EQ(f, frame.sample_rate_hz_);

- EXPECT_EQ(f / 100, frame.samples_per_channel_);

+ EXPECT_EQ(static_cast<size_t>(f / 100), frame.samples_per_channel_);

}

PausePlaying();

EXPECT_EQ(0, voe_xmedia_->SetExternalMixing(channel_, false));