Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(78)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1224123002: Update audio code to use size_t more correctly, webrtc/modules/ portion. (Closed)

Created:
5 years, 5 months ago by Peter Kasting
Modified:
5 years, 4 months ago
CC:
tterriberry_mozilla.com, webrtc-reviews_webrtc.org
Base URL:
https://chromium.googlesource.com/external/webrtc@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Update audio code to use size_t more correctly, webrtc/modules/ portion. This is a piece of https://codereview.webrtc.org/1230503003 , split out to a separate change to make reviewing easier. BUG=chromium:81439 TEST=none

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+49 lines, -47 lines) Patch
M webrtc/modules/audio_conference_mixer/source/audio_conference_mixer_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/audio_conference_mixer/source/audio_conference_mixer_impl.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M webrtc/modules/audio_conference_mixer/source/audio_frame_manipulator.cc View 3 chunks +5 lines, -5 lines 0 comments Download
M webrtc/modules/audio_conference_mixer/source/level_indicator.h View 2 chunks +3 lines, -1 line 0 comments Download
M webrtc/modules/audio_conference_mixer/source/level_indicator.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M webrtc/modules/interface/module_common_types.h View 10 chunks +11 lines, -11 lines 0 comments Download
M webrtc/modules/utility/interface/audio_frame_operations.h View 2 chunks +2 lines, -2 lines 0 comments Download
M webrtc/modules/utility/interface/file_player.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/utility/source/audio_frame_operations.cc View 5 chunks +7 lines, -7 lines 0 comments Download
M webrtc/modules/utility/source/audio_frame_operations_unittest.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M webrtc/modules/utility/source/file_player_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/utility/source/file_player_impl.cc View 4 chunks +5 lines, -6 lines 0 comments Download
M webrtc/modules/utility/source/file_player_unittests.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M webrtc/modules/utility/source/file_recorder_impl.cc View 3 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Peter Kasting
asapersson: webrtc/modules/utility/ OWNERS andrew: rest
5 years, 5 months ago (2015-07-09 23:12:48 UTC) #2
åsapersson
lgtm
5 years, 5 months ago (2015-07-10 06:27:08 UTC) #3
Peter Kasting
Since andrew is being somewhat unresponsive, adding henrika as an alternate top-level OWNER in hopes ...
5 years, 5 months ago (2015-07-17 00:15:35 UTC) #5
henrika_webrtc
5 years, 5 months ago (2015-07-17 07:37:22 UTC) #6 
LGTM

webrtc/modules/audio_conference_mixer/
webrtc/modules/interface/

Powered by Google App Engine
This is Rietveld 408576698