Issue 1224093003: Update audio code to use size_t more correctly, talk/ portion.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1224093003: Update audio code to use size_t more correctly, talk/ portion. (Closed)

Created:
5 years, 5 months ago by Peter Kasting

Modified:
5 years, 4 months ago

Reviewers:
pthatcher1

CC:
Andrew MacDonald, interface-changes_webrtc.org, niklas.enbom, qiang.lu, rwolff_gocast.it, tterriberry_mozilla.com, webrtc-reviews_webrtc.org, yujie_mao (webrtc)

Base URL:
https://chromium.googlesource.com/external/webrtc@master

Target Ref:
refs/pending/heads/master

Project:
webrtc

Visibility:
Public.

More Reviews

Description

Update audio code to use size_t more correctly, talk/ portion. This is a piece of https://codereview.webrtc.org/1230503003 , split out to a separate change to make reviewing easier. BUG=chromium:81439 TEST=none

Patch Set 1 #

Created: 5 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+30 lines, -28 lines)			Patch
M	talk/app/webrtc/mediastreamhandler.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	talk/app/webrtc/mediastreamhandler.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	talk/app/webrtc/mediastreaminterface.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	talk/app/webrtc/test/fakeaudiocapturemodule.h	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	talk/app/webrtc/test/fakeaudiocapturemodule.cc	View	3 chunks	+5 lines, -5 lines	0 comments	Download
M	talk/app/webrtc/test/fakeaudiocapturemodule_unittest.cc	View	4 chunks	+11 lines, -11 lines	0 comments	Download
M	talk/media/base/audiorenderer.h	View	2 chunks	+3 lines, -1 line	0 comments	Download
M	talk/media/base/fakemediaengine.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	talk/media/webrtc/fakewebrtcvoiceengine.h	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	talk/media/webrtc/webrtcvoiceengine.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	talk/media/webrtc/webrtcvoiceengine.cc	View	2 chunks	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 3 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

lgtm

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages