Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(182)

Issue 1222233002: Fix occurrences of const typed declaration without initialization (Closed)

Created:
5 years, 5 months ago by eblima
Modified:
5 years, 5 months ago
Reviewers:
tommi, aluebs-webrtc
CC:
webrtc-reviews_webrtc.org
Base URL:
https://chromium.googlesource.com/external/webrtc/trunk/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Fix occurrences of const typed declaration without initialization This fixes compilation errors as the following: error: constructor must explicitly initialize the const member BUG=506663 R=aluebs@webrtc.org, tommi@webrtc.org Signed-off-by: Eduardo Lima (Etrunko) <eduardo.lima@intel.com>; Committed: https://crrev.com/894ad94302d311fd3f193080dd881a1a3439dbe3 Cr-Commit-Position: refs/heads/master@{#9538}

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : rebase on top of webrtc tree #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -3 lines) Patch
M webrtc/modules/audio_processing/include/audio_processing.h View 1 2 1 chunk +3 lines, -1 line 0 comments Download
M webrtc/p2p/client/basicportallocator.cc View 1 2 2 chunks +4 lines, -2 lines 0 comments Download

Messages

Total messages: 17 (7 generated)
eblima
5 years, 5 months ago (2015-07-02 19:24:05 UTC) #1
tommi
lgtm
5 years, 5 months ago (2015-07-03 08:39:00 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1222233002/1
5 years, 5 months ago (2015-07-03 08:39:07 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: linux_msan on tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/linux_msan/builds/3510) mac_asan on tryserver.webrtc (JOB_FAILED, ...
5 years, 5 months ago (2015-07-03 08:40:00 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1222233002/20001
5 years, 5 months ago (2015-07-03 11:58:34 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: mac on tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/mac/builds/8508)
5 years, 5 months ago (2015-07-03 11:59:14 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1222233002/40001
5 years, 5 months ago (2015-07-03 13:18:33 UTC) #14
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 5 months ago (2015-07-03 15:34:38 UTC) #15
commit-bot: I haz the power
Patchset 3 (id:??) landed as https://crrev.com/894ad94302d311fd3f193080dd881a1a3439dbe3 Cr-Commit-Position: refs/heads/master@{#9538}
5 years, 5 months ago (2015-07-03 15:34:49 UTC) #16
aluebs-webrtc
5 years, 5 months ago (2015-07-06 19:22:25 UTC) #17
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698