Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(273)

Issue 1222193003: Remove decoder-thread instantiation for senders. (Closed)

Created:
5 years, 5 months ago by pbos-webrtc
Modified:
5 years, 5 months ago
Reviewers:
tommi, stefan-webrtc
CC:
webrtc-reviews_webrtc.org, yujie_mao (webrtc), stefan-webrtc, tterriberry_mozilla.com, andresp, perkj_webrtc, mflodman
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Remove decoder-thread instantiation for senders. Reduces number of running (high-priority) threads, even though the thread was practically blocked all the time. Also adding DCHECKs to make sure we're not trying to use certain sender-only methods on receivers and vice versa. BUG=webrtc:1675, webrtc:1695 R=stefan@webrtc.org Committed: https://crrev.com/cd4a9bd22596c624e5a7f2646a80a40317451882 Cr-Commit-Position: refs/heads/master@{#9534}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -31 lines) Patch
M webrtc/video_engine/vie_channel.h View 2 chunks +4 lines, -4 lines 0 comments Download
M webrtc/video_engine/vie_channel.cc View 7 chunks +19 lines, -27 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
pbos-webrtc
PTAL, yay.
5 years, 5 months ago (2015-07-02 12:32:47 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1222193003/1
5 years, 5 months ago (2015-07-02 12:33:00 UTC) #3
stefan-webrtc
lgtm
5 years, 5 months ago (2015-07-02 12:40:33 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1222193003/1
5 years, 5 months ago (2015-07-02 12:41:19 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 5 months ago (2015-07-02 13:32:22 UTC) #8
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/cd4a9bd22596c624e5a7f2646a80a40317451882 Cr-Commit-Position: refs/heads/master@{#9534}
5 years, 5 months ago (2015-07-02 13:32:28 UTC) #9
tommi
Nice change (lgtm!). I don't suppose we can start adding thread checks for variables such ...
5 years, 5 months ago (2015-07-06 09:44:29 UTC) #11
pbos-webrtc
5 years, 5 months ago (2015-07-06 09:55:12 UTC) #12
Message was sent while issue was closed.
On 2015/07/06 09:44:29, tommi (webrtc) wrote:
> Nice change (lgtm!).  I don't suppose we can start adding thread checks for
> variables such as sender_, the start/stop methods etc that don't have locks,
> etc?

Maybe. Will keep it in mind, but most things here are subject to Major
Refactoring and being moved around for now, so "uh maybe later is easier". It
might also be straight-up doable. Not sure. :)

Powered by Google App Engine
This is Rietveld 408576698